From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Dec 10 05:47:14 2010 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B46F1065675; Fri, 10 Dec 2010 05:47:14 +0000 (UTC) (envelope-from ek@purplehat.org) Received: from morbid.purplehat.org (morbid.purplehat.org [206.225.83.29]) by mx1.freebsd.org (Postfix) with ESMTP id B2D548FC14; Fri, 10 Dec 2010 05:47:13 +0000 (UTC) Received: from localhost (morbid.purplehat.org [206.225.83.29]) by morbid.purplehat.org (Postfix) with ESMTP id 88D0685B8B7; Thu, 9 Dec 2010 21:29:27 -0800 (PST) Received: from morbid.purplehat.org ([206.225.83.29]) by localhost (morbid.purplehat.org [206.225.83.29]) (amavisd-maia, port 10024) with ESMTP id 72596-03; Thu, 9 Dec 2010 21:29:27 -0800 (PST) Received: from [192.168.1.3] (mx2.purplehat.org [67.190.82.109]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: ek@purplehat.org) by morbid.purplehat.org (Postfix) with ESMTPSA id 0EA5C85B8B1; Thu, 9 Dec 2010 21:29:26 -0800 (PST) Message-ID: <4D01BAB7.2040802@purplehat.org> Date: Thu, 09 Dec 2010 22:29:27 -0700 From: "Janky Jay, III" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.15) Gecko/20101027 Thunderbird/3.0.10 MIME-Version: 1.0 To: ohauer@FreeBSD.org References: <201012051932.oB5JWw0l058016@freefall.freebsd.org> In-Reply-To: <201012051932.oB5JWw0l058016@freefall.freebsd.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=4B1A0B24 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/151637: Update port: security/maia Much needed updates for Perl and PHP. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2010 05:47:14 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Olli, Excellent information. Thanks! I'll make these changes as soon as I can and re-submit the port (in diff format as I hear that's the proper way.) Regards, Janky Jay, III On 12/05/2010 12:32 PM, ohauer@FreeBSD.org wrote: > Synopsis: Update port: security/maia Much needed updates for Perl and PHP. > > State-Changed-From-To: open->feedback > State-Changed-By: ohauer > State-Changed-When: Sun Dec 5 19:31:55 UTC 2010 > State-Changed-Why: > I'll take it. > > Hi Janky Jay, > > I've taken a look over your second patch, looks good so far but I have > a view questions and suggestions. > > Are those php modules really needed? > For example if I do not use mysql but postgres insted do I need the > module mysql and mysqli? > > If this is not the case then this the preferred solution > > .if defined(WITH_MYSQL) > USE_MYSQL= yes > USE_PHP+= mysql mysqli > RUN_DEPENDS+= ${SITE_PERL}/${PERL_ARCH}/DBD/mysql.pm:${PORTSDIR}/databases/p5-DBD-mysql > .endif > > Same for postgres and others. > > As you see in the Makefile snipped before I removed mysql-server > with USE_MYSQL, same for postgres and apache. > Maybe the sql servers are running on a different machine/cluster? > > In your first patch you had additional php-filter, is this module not > needed or was it forgotten in the second patch? > > > It seems you rolled the tar file from the maia 1.0 branch, rev 1499. > > Here I have the following suggestion. > Do not use the same name for the sources, use DISTNAME instead. > > For example: > svn co https://www.maiamailguard.com/svn/branches/1.0 -r1500 maia-1.0.2a-r1500 > > Now you can use in Makefile > DISTNAME= ${PORTNAME}-${PORTVERSION}-${SVNREVISION} > and > SVNREVISION= r1500 > > This way there is no distinfo clash and it helps paranoid users like > me to compair the sources ;) > > > I've implemented some of the suggested changes, within an update to > svn revision 1500. You can find them here. > > Diff to current port > http://people.freebsd.org/~ohauer/diffs/PR_151637-maia_2010-12-05.diff > > New resulting port (svn updated to rev 1500) > http://people.freebsd.org/~ohauer/diffs/PR_151637-maia_2010-12-05.shar > > Please look into the php modules and if possible build the source tar > as suggested. > > -- > Regards, > olli > > > Responsible-Changed-From-To: freebsd-ports-bugs->ohauer > Responsible-Changed-By: ohauer > Responsible-Changed-When: Sun Dec 5 19:31:55 UTC 2010 > Responsible-Changed-Why: > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=151637 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk0BurcACgkQZ5znzUsaCyRoVQCeLVNDfel7i3+YHA+BSuglAaUI UQwAn2Tl9g3FehP8dOsGpdGD8h8SkJsi =L03u -----END PGP SIGNATURE-----