Date: Mon, 11 Mar 2019 06:23:16 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Justin Hibbits <chmeeedalf@gmail.com> Cc: svn-src-head@freebsd.org, Justin Hibbits <jhibbits@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r344960 - head/sys/powerpc/powerpc Message-ID: <20190311062316.GA41091@FreeBSD.org> In-Reply-To: <20190310171640.31bb9c54@titan.knownspace> References: <201903090318.x293IcLc023548@repo.freebsd.org> <20190309085058.GA60945@FreeBSD.org> <20190310171640.31bb9c54@titan.knownspace>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 10, 2019 at 05:16:40PM -0500, Justin Hibbits wrote: > On Sat, 9 Mar 2019 08:50:58 +0000 > Alexey Dokuchaev <danfe@freebsd.org> wrote: > > On Sat, Mar 09, 2019 at 03:18:38AM +0000, Justin Hibbits wrote: > > > New Revision: 344960 > > > URL: https://svnweb.freebsd.org/changeset/base/344960 > > > > > > Log: > > > powerpc: Print trap frame address for fatal traps > > > > > > MFC after: 1 week > > > > > > Modified: head/sys/powerpc/powerpc/trap.c > > > ... > > > current msr = 0x%" PRIxPTR "\n", mfmsr()); printf(" > > > lr = 0x%" PRIxPTR " (0x%" PRIxPTR ")\n", frame->lr, > > > frame->lr - (register_t)(__startkernel - KERNBASE)); > > > + printf(" frame = %p\n", frame); > > > printf(" curthread = %p\n", curthread); > > > > Some of those are printed with %PRIxPTR, some with %p. Perhaps this > > inconsistency can be avoided? > > PRIxPTR is for printing a pointer-like value that's not a pointer. > The other values printed are of type register_t, not void *. Ah, okay, I've somehow missed that, thanks for pointing this out. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190311062316.GA41091>