From owner-freebsd-ports Sat Feb 9 14:31:37 2002 Delivered-To: freebsd-ports@freebsd.org Received: from lists.unixathome.org (lists.unixathome.org [210.48.103.158]) by hub.freebsd.org (Postfix) with ESMTP id 9E3F737B405; Sat, 9 Feb 2002 14:31:30 -0800 (PST) Received: from wocker (lists.unixathome.org [210.48.103.158]) by lists.unixathome.org (8.11.6/8.11.6) with ESMTP id g19MUwi67725; Sun, 10 Feb 2002 11:30:59 +1300 (NZDT) (envelope-from dan@lists.unixathome.org) Message-Id: <200202092230.g19MUwi67725@lists.unixathome.org> From: "Dan Langille" Organization: DVL Software Limited To: Mario Sergio Fujikawa Ferreira Date: Sat, 9 Feb 2002 17:30:44 -0500 MIME-Version: 1.0 Subject: Re: %SUBDIR% not being expanded during make -V MASTER_SITES Reply-To: dan@langille.org Cc: "David W. Chapman Jr." , ports@FreeBSD.org, jeremy@external.org In-reply-to: <20020209212930.1523.qmail@exxodus.fedaykin.here> References: <200202091748.g19Hm7i65482@lists.unixathome.org>; from dan@langille.org on Sat, Feb 09, 2002 at 12:47:08PM -0500 X-mailer: Pegasus Mail for Windows (v4.01) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT Content-description: Mail message body Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On 9 Feb 2002 at 19:29, Mario Sergio Fujikawa Ferreira wrote: > On Sat, Feb 09, 2002 at 12:47:08PM -0500, Dan Langille wrote: > > On 9 Feb 2002 at 11:27, David W. Chapman Jr. wrote: > > > > > On Sat, Feb 09, 2002 at 11:47:58AM -0500, Dan Langille wrote: > > > > I'm not picking on biology/kinemage, I've seen this in several ports. > > > > > > > > Should the output contain %SUBDIR%? > > > > > > > > It's not what I expected. > > > > > > I believe this was broken a few days ago and not fixed yet. > > > > Any reason it's not fixed? Does someone need to be proded? > > As far as I know, it is supposed to be that way. At least, > it is the way I "devised" this. It is due to the MASTER_SITES_NN > patch, it is better to not touch the MASTER_SITES variables directly. > It is not guaranteed that accessing variables will produce > anything useable. The good way is to use targets such as mentioned in > line 1529 of bsd.port.mk > > # synonyms, mnemonics > master-sites-all: master-sites-ALL > patch-sites-all: patch-sites-ALL > master-sites-default: master-sites-DEFAULT > patch-sites-default: patch-sites-DEFAULT > > # compatibility with old behavior > master-sites: master-sites-DEFAULT > patch-sites: patch-sites-DEFAULT > > Try either 'make master-sites-all' or 'make patch-sites-all' OK, I'll modify FreshPorts to use "make master-sites-all". At present it does one big call to make: make -V PORTNAME -V PKGNAME -V DESCR -V CATEGORIES -V PORTVERSION -V PORTREVISION -V COMMENT -V MAINTAINER -V EXTRACT_SUFX -V MASTER_SITES -V BUILD_DEPENDS -V RUN_DEPENDS -V FORBIDDEN -V BROKEN I'll remove the MASTERSITES part and replace it with a "make master-sites- all" which seems to do the same. Were there any other changed in there? Are there any similar changes planned for the near future? thanks -- Dan Langille The FreeBSD Diary - http://freebsddiary.org/ - practical examples To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message