Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 Oct 2019 14:43:02 +0200
From:      Tobias Kortkamp <tobik@freebsd.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r515252 - head/x11/cool-retro-term
Message-ID:  <20191023124302.GA64150@urd.tobik.me>
In-Reply-To: <201910231211.x9NCBOf2070687@repo.freebsd.org>
References:  <201910231211.x9NCBOf2070687@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--4Ckj6UjgE2iN1+kY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 23, 2019 at 12:11:24PM +0000, Alexey Dokuchaev wrote:
> Author: danfe
> Date: Wed Oct 23 12:11:24 2019
> New Revision: 515252
> URL: https://svnweb.freebsd.org/changeset/ports/515252
>=20
> Log:
>   - Switch to USES+=3Dcompiler:c++11-lang to unbreak on PowerPC instead
>     of the approach taken in r513793 (Clang was never required for this
>     port, any not-so-ancient compiler would suffice)
>   - Sort the values on the USES list; avoid hardcoding version numbers
> [...]
> @@ -16,24 +16,15 @@ GH_ACCOUNT=3D	Swordfish90
>  GH_PROJECT=3D	qmltermwidget:qtw
>  GH_TAGNAME=3D	0.2.0:qtw
> [...]
>  post-extract:
>  	@${RMDIR} ${WRKSRC}/qmltermwidget
> -	@${LN} -s ../qmltermwidget-0.2.0 ${WRKSRC}/qmltermwidget
> +	@${LN} -s ../qmltermwidget-${GH_TAGNAME_qtw} ${WRKSRC}/qmltermwidget

This is very complicated and unnecessary.  post-extract should be
removed and replaced with

GH_SUBDIR=3D	qmltermwidget:qtw

and then GH_PROJECT, GH_TAGNAME, GH_SUBDIR with the more readable
GH_TUPLE.

--4Ckj6UjgE2iN1+kY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl2wStNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1
N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF
H2FaFAgApxdXyNKwdkyd1hMeUvgTjcL/MMkKoI7VjancPuf/iQP9zyrsau2lErJK
xvCgD+zAvvMcGMySqZHE1eIu48bYzqbGSrvBnv0DLw8bDj7cQGXVhUCtoqinZ+e7
JQtkqJF/5sUQGoMpVHFlPNLkX4Ph7v9qsZJs083N5wyNSH4v93txQlTDmVQS+Vhy
rjfWEA8e9mfqXTiYr/JNhsRr+tti82cxuZLtKdhewNdw9xFkBZydQUGJOh+NlJ2+
/OkTqapvqSPFcpalaxQgb31Nvatfr3fOwh9L8dLEL+9/dtl0bZE3odTLjPaMettq
h7sfefS3zOUAPYAvp7m2ZYQiAFb2aw==
=QzZI
-----END PGP SIGNATURE-----

--4Ckj6UjgE2iN1+kY--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191023124302.GA64150>