Date: Tue, 7 Feb 1995 13:32:14 -0700 From: Nate Williams <nate@sneezy.sri.com> To: Garrett Wollman <wollman@halloran-eldar.lcs.mit.edu>, Bruce Evans <bde@zeta.org.au> Cc: CVS-commiters@freefall.cdrom.com, cvs-usrsbin@freefall.cdrom.com Subject: Re: cvs commit: src/usr.sbin/lsdev i386.c Message-ID: <9502072032.AA02093@rocky.sri.MT.net> In-Reply-To: Garrett Wollman <wollman@halloran-eldar.lcs.mit.edu> "Re: cvs commit: src/usr.sbin/lsdev i386.c" (Feb 7, 14:34)
next in thread | previous in thread | raw e-mail | index | archive | help
> > I asked Stefan to think about including less goop in <machine/devconf.h>. > > This resulted in the above commit. But the above commit was wrong because > > PCI_INTERNAL_LEN is not used directly by i386.c; it is apparently required > > for <machine/devconf.h> to be self-contained. This was fixed before you > > looked at the sources. > > Hmmm. I don't belong to that religion that says that no header files > should ever include other header files and it's the responsibility for > the poor programmer to make sure that every program includes every > header file in the universe directly in case it's needed somewhere. I agree, but there is a happy medium. I've seen *way* too many problems with programs that include every other header file so that the poor programmer doesn't have to include but one header, and it *WILL* cause that poor programmer no end of grief. Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9502072032.AA02093>