From owner-svn-ports-head@FreeBSD.ORG  Sat Feb 16 14:41:41 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 477EEB3C;
 Sat, 16 Feb 2013 14:41:41 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-ie0-x232.google.com (mail-ie0-x232.google.com
 [IPv6:2607:f8b0:4001:c03::232])
 by mx1.freebsd.org (Postfix) with ESMTP id 00000D5B;
 Sat, 16 Feb 2013 14:41:40 +0000 (UTC)
Received: by mail-ie0-f178.google.com with SMTP id c13so5787342ieb.23
 for <multiple recipients>; Sat, 16 Feb 2013 06:41:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=Lj+ejHV1e+B02ouXqkFbygMlsKCOeKcrEkaiHtLIyN0=;
 b=OqnO6U1r4BBz+IKYg8cxB0Q4N6CexeSZoQug7ggBvg1yoxTMofggpX3ElKazk4lzRO
 LXxeJg3wigBixR7wZCMLwUutp02U/6LHl0PZ3P0jKHmbGmYtsq+C3GHp0pHzSID4Dzkh
 NpM3MeaWzv8ZHcDfBKIx1Ex1i+lwi+ps2tNnb9+fPNEqpHUppSZ6JuHnWm9UN9K6upG2
 BFHc7nDvl834bSMilSzRd46Rz4pvtKyM3C2snBqABV47Fnhax/pU1b2DcEl2Y3NYid8v
 1RTgwPQRmU3LrOIRj2tqCSt5yX7fjapU0M9mDcZALx0FSXO7XMg0/Qi/Y/0RS82EZnEE
 xISQ==
MIME-Version: 1.0
X-Received: by 10.50.178.10 with SMTP id cu10mr4758418igc.75.1361025700664;
 Sat, 16 Feb 2013 06:41:40 -0800 (PST)
Received: by 10.64.63.12 with HTTP; Sat, 16 Feb 2013 06:41:39 -0800 (PST)
Received: by 10.64.63.12 with HTTP; Sat, 16 Feb 2013 06:41:39 -0800 (PST)
In-Reply-To: <20130216152406.04fe7cff5e79f9f2eb623140@critical.ch>
References: <201302161421.r1GELYfr013815@svn.freebsd.org>
 <20130216152406.04fe7cff5e79f9f2eb623140@critical.ch>
Date: Sat, 16 Feb 2013 14:41:39 +0000
Message-ID: <CADLo839BjB8Uf7L9Gv0bK4XoUX2ediWjX1oAk0iw6i69L8J3Vg@mail.gmail.com>
Subject: Re: svn commit: r312354 - head/audio/xmp
From: Chris Rees <utisoft@gmail.com>
To: Emanuel Haupt <ehaupt@critical.ch>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Emanuel Haupt <ehaupt@freebsd.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Feb 2013 14:41:41 -0000

On 16 Feb 2013 14:24, "Emanuel Haupt" <ehaupt@critical.ch> wrote:
>
> Emanuel Haupt <ehaupt@FreeBSD.org> wrote:
> > Author: ehaupt
> > Date: Sat Feb 16 14:21:33 2013
> > New Revision: 312354
> > URL: http://svnweb.freebsd.org/changeset/ports/312354
> >
> > Log:
> >   - Work around a case where .if !exists(${ETCDIR}/${f}) fails
> >   - Consistent usage of %%ETCDIR%%
> >
> > Modified:
> >   head/audio/xmp/Makefile
> >   head/audio/xmp/pkg-plist
> >
> > Modified: head/audio/xmp/Makefile
> >
==============================================================================
> > --- head/audio/xmp/Makefile   Sat Feb 16 14:10:55 2013
> > (r312353) +++ head/audio/xmp/Makefile Sat Feb 16 14:21:33
> > 2013  (r312354) @@ -50,11 +50,9 @@ post-patch:
> >       @${REINPLACE_CMD} -e 's|\ install-conf||'
> > ${WRKSRC}/Makefile.in
> >  post-install:
> > -     ${MKDIR} ${PREFIX}/etc/xmp
> > +     ${MKDIR} ${ETCDIR}
> >  .for f in ${CONFIG_FILES}
>
> > -.if !exists(${ETCDIR}/${f})
>
> Can someone explain why this fails?

I can't see from the patch, but I assume you forgot to include
bsd.port.pre.mk.

I would encourage the latter version anyway, since it preserves the lazy
evaluation of ETCDIR, and doesn't cause a stat on every read of the
Makefile.

Chris