Date: Mon, 14 Oct 2013 08:10:41 -0400 (EDT) From: Keith White <kwhite@site.uottawa.ca> To: Andriy Gapon <avg@FreeBSD.org> Cc: freebsd-current@FreeBSD.org Subject: Re: ZFS panic (dn->dn_datablkshift != 0) with r256304 and send/recv Message-ID: <alpine.BSF.2.00.1310140808410.2365@localhost.my.domain> In-Reply-To: <525B797C.4050500@FreeBSD.org> References: <alpine.BSF.2.00.1310132013330.1414@localhost.my.domain> <525B797C.4050500@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 14 Oct 2013, Andriy Gapon wrote: > on 14/10/2013 03:34 Keith White said the following: >> I get the following assert failure with a recent current: >> >> panic: solaris assert: dn->dn_datablkshift != 0, file: >> /usr/src/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_tx.c, >> line: 638 > > Please see https://www.illumos.org/issues/4188 > The current best known fix is to simply drop the assertion. > ... Thanks! It works for me. Receive completes, and filesystems compare the same. Index: /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_tx.c =================================================================== --- /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_tx.c (revision 256304) +++ /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_tx.c (working copy) @@ -635,7 +635,7 @@ uint64_t start = off >> shift; uint64_t end = (off + len) >> shift; - ASSERT(dn->dn_datablkshift != 0); + /* XXX may be false alarm: ASSERT(dn->dn_datablkshift != 0); XXX */ ASSERT(dn->dn_indblkshift != 0); zio = zio_root(tx->tx_pool->dp_spa, > Though, I am not entirely sure if this will be the final solution. I'll > double-check with Matt. > ...keith
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1310140808410.2365>