From owner-cvs-all Sat Apr 20 8:19:16 2002 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 0C1B337B417; Sat, 20 Apr 2002 08:19:04 -0700 (PDT) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 957F4534E; Sat, 20 Apr 2002 17:19:02 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: "Andrey A. Chernov" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh session.c References: <200204200956.g3K9uAM11914@freefall.freebsd.org> From: Dag-Erling Smorgrav Date: 20 Apr 2002 17:19:02 +0200 In-Reply-To: Message-ID: Lines: 14 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Dag-Erling Smorgrav writes: > "Andrey A. Chernov" writes: > > Log: > > Fix TZ & TERM handling for use_login case of rev. 1.24 > This patch is incorrect. It will cause a segmentation fault if TZ is > not defined, which is the case for most people. Please back it out. Sorry, this comment applies to 1.24, and 1.26 fixes it. In the future, please seek review for such patches. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message