Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Jul 1999 14:08:49 -0600
From:      Nate Williams <nate@mt.sri.com>
To:        "Brian F. Feldman" <green@FreeBSD.org>
Cc:        Nate Williams <nate@mt.sri.com>, hackers@FreeBSD.org, freebsd-ipfw@FreeBSD.org
Subject:   Re: securelevel and ipfw zero
Message-ID:  <199907282008.OAA02877@mt.sri.com>
In-Reply-To: <Pine.BSF.4.10.9907281604390.92555-100000@janus.syracuse.net>
References:  <199907282000.OAA02728@mt.sri.com> <Pine.BSF.4.10.9907281604390.92555-100000@janus.syracuse.net>

Next in thread | Previous in thread | Raw E-Mail | Index | Archive | Help
> > > @@ -302,14 +303,15 @@
> > >  	struct ifnet *rif, struct ifnet *oif)
> > >  {
> > >      if (ip) {
> > > +	struct tcphdr *const tcp = (struct tcphdr *)((u_int32_t *)ip+ip->ip_hl);
> > > +	struct udphdr *const udp = (struct udphdr *)((u_int32_t *)ip+ip->ip_hl);
> > > +	struct icmp *const icmp = (struct icmp *)((u_int32_t *)ip+ip->ip_hl);
> > >  	static u_int64_t counter;
> > > -	struct tcphdr *const tcp = (struct tcphdr *) ((u_int32_t *) ip+ ip->ip_hl);
> > > -	struct udphdr *const udp = (struct udphdr *) ((u_int32_t *) ip+ ip->ip_hl);
> > > -	struct icmp *const icmp = (struct icmp *) ((u_int32_t *) ip + ip->ip_hl);
> > > -	int count;
> > > +	u_int64_t count;
> > 
> > These are mostly change for changes sake, and make it difficult to see
> > the functional changes.  Please limit your changes to changes, and not
> > just to add stylistic differences.  While I may agree with them, they
> > detract from the review process.
> 
> These were changes that were necessary to make ipfw readable enough that
> I could work with it in this area. They aren't just to clean it up, or
> just for change's sake. They need to stay in.

C'mon now, re-ording the lines is *certainly* not necessary to work.

*rant on*
Brian, FreeBSD isn't your private playground for playing around, this is
a group project, and you gotta follow the rules, or you don't get to
play with the rest of the folks....
*rant off*




Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ipfw" in the body of the message




Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?199907282008.OAA02877>