From owner-p4-projects@FreeBSD.ORG Sun Dec 28 04:19:34 2003 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id ABC8B16A4E2; Sun, 28 Dec 2003 04:19:33 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7BC6C16A502 for ; Sun, 28 Dec 2003 04:19:19 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CAD3043D41 for ; Sun, 28 Dec 2003 04:19:18 -0800 (PST) (envelope-from jmallett@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id hBSCJI0B020047 for ; Sun, 28 Dec 2003 04:19:18 -0800 (PST) (envelope-from jmallett@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id hBSCJIp4020044 for perforce@freebsd.org; Sun, 28 Dec 2003 04:19:18 -0800 (PST) (envelope-from jmallett@freebsd.org) Date: Sun, 28 Dec 2003 04:19:18 -0800 (PST) Message-Id: <200312281219.hBSCJIp4020044@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to jmallett@freebsd.org using -f From: Juli Mallett To: Perforce Change Reviews Subject: PERFORCE change 44443 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Dec 2003 12:19:34 -0000 http://perforce.freebsd.org/chv.cgi?CH=44443 Change 44443 by jmallett@jmallett_oingo on 2003/12/28 04:18:52 Delete NetBSD's much "nicer" and much more complete ARCBIOS code in favor of my ARCS code which "mostly does the job." The NetBSD way of using packed structures is nice, and certainly easy to code, but makes dealing with ABI issues difficult. If it were trivial to say "switch to the o64 ABI for calling this" then I might not mind it so much, but it'd end up very, very full of macros before function pointers, and I'm sure GCC would get argument translation wrong anyway. Not to mention having to use my ArcPointer_t stuff anyway for structure sizing. NetBSD code is still a good reference for functions, etc. Note this also gets rid of their (surely nicer) TTY code. Affected files ... .. //depot/projects/mips/sys/dev/arcbios/arcbios.c#12 delete .. //depot/projects/mips/sys/dev/arcbios/arcbios.h#5 delete .. //depot/projects/mips/sys/dev/arcbios/arcbios_tty.c#5 delete .. //depot/projects/mips/sys/dev/arcbios/arcbiosvar.h#5 delete Differences ...