Date: Wed, 12 Mar 2014 07:13:01 +0100 From: vermaden <vermaden@interia.pl> To: Andrew Hotlab <andrew.hotlab@hotmail.com> Cc: "ports@freebsd.org" <ports@freebsd.org>, Bryan Drewery <bdrewery@freebsd.org> Subject: RE: [patch] sysutils/beadm Message-ID: <wxrnxfbyqkgnatadyuho@cyit> In-Reply-To: <DUB118-W6B066AC17E8CC6D0F2676F6740@phx.gbl> References: <DUB129-W68936A08892FE3CE358447F69D0@phx.gbl> <DUB118-W6B066AC17E8CC6D0F2676F6740@phx.gbl>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi. Merged, along with check if zpool.cache file exists: https://github.com/vermaden/beadm/commit/748d2f2b189581e1cef209f84accd250e3= 5e0954 Regards, vermaden Od: "Andrew Hotlab" <andrew.hotlab@hotmail.com> Do: "Bryan Drewery" <bdrewery@freebsd.org>; "vermaden@interia.pl" <vermaden= @interia.pl>;=20 Wys=C5=82ane: 23:23 Poniedzia=C5=82ek 2014-03-10 Temat: RE: [patch] sysutils/beadm > > Date: Mon, 10 Mar 2014 16:11:16 -0500 > > From: bdrewery@FreeBSD.org > > To: andrew.hotlab@hotmail.com; vermaden@interia.pl > > CC: ports@freebsd.org > > Subject: Re: [patch] sysutils/beadm > > > > On 2014-02-13 16:19, Andrew Hotlab wrote: > >> > >> In my setup I have the following layout (several datasets for /usr, > >> /var, etc.): > >> > >> At this moment the utility does not seems to be able to manage this > >> scheme, since it sets the mountpoint property as "legacy" for all > >> datasets under the root, thus preventing to automatically mount any > >> subdirectory at boot. > >> I've tested this simple solution (to let do the job to the canmount > >> property), and it seems to solve the problem without affecting the > >> behavior when all system folders are located under a single root > >> dataset (please see the patch below). I'd be glad if you'll include it > >> in the next port revision. > >> > >> I'm at your disposal for any further detail. > >> > >> Best regards. > >> > >> Andrew > >> > >> > >> --- ./beadm 2014-01-11 17:08:31.112384992 +0100 > >> +++ /usr/local/sbin/beadm 2014-01-11 17:06:38.620706860 +0100 > >> @@ -505,7 +505,7 @@ > >> if [ ${MOUNT} -eq 0 ] > >> then > >> zfs umount ${POOL}/${BEDS}/${2} > >> - zfs set mountpoint=3Dlegacy ${POOL}/${BEDS}/${2} > >> + zfs set mountpoint=3D/ ${POOL}/${BEDS}/${2} > > > > I've tested this and agree with it. It should be added upstream as it > > makes it simpler to have these extra /mounts. Otherwise you have to > > explicitly set them with mountpoint=3D/usr, /var, instead of inheriting > > from the / dataset. > > The problems I mentioned were probably before we got the 'canmount' > > support in to prevent remounting over /. > > > >> fi > >> fi > >> if ! zpool set bootfs=3D${POOL}/${BEDS}/${2} ${POOL} 1> /dev/null 2> > >> /dev/null > >> @@ -518,6 +518,7 @@ > >> ZFS_LIST=3D$( zfs list -H -o name -r ${POOL}/${BEDS} ) > >> # disable automatic mount on all inactive boot environments > >> echo "${ZFS_LIST}" \ > >> + | grep -v "^${POOL}/${BEDS}$" \ > > > > Note that this change is unrelated. > > > >> | grep -v "^${POOL}/${BEDS}/${2}$" \ > >> | grep -v "^${POOL}/${BEDS}/${2}/" \ > >> | while read NAME > > >=20 > Great! I'm glad to be helpful. I'll look forward to see the change commit= ted to the Ports repository. >=20 > Thank you so much for this wonderful tool! >=20 > Regards. >=20 > Andrew =20 =
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?wxrnxfbyqkgnatadyuho>