From owner-svn-ports-all@freebsd.org Wed Feb 1 05:25:30 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AAA7ACCD153; Wed, 1 Feb 2017 05:25:30 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 72FE0B65; Wed, 1 Feb 2017 05:25:30 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v115PTQm086824; Wed, 1 Feb 2017 05:25:29 GMT (envelope-from jbeich@FreeBSD.org) Received: (from jbeich@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v115PT8T086823; Wed, 1 Feb 2017 05:25:29 GMT (envelope-from jbeich@FreeBSD.org) Message-Id: <201702010525.v115PT8T086823@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jbeich set sender to jbeich@FreeBSD.org using -f From: Jan Beich Date: Wed, 1 Feb 2017 05:25:29 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r432970 - head/audio/mixxx/files X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2017 05:25:30 -0000 Author: jbeich Date: Wed Feb 1 05:25:29 2017 New Revision: 432970 URL: https://svnweb.freebsd.org/changeset/ports/432970 Log: audio/mixxx: unbreak with clang 4.0 src/widget/wdisplay.cpp:89:19: error: ordered comparison between pointer and zero ('QPixmap **' and 'int') if (m_pPixmaps>0) ~~~~~~~~~~^~ PR: 216354 Reported by: antoine (via exp-run) Submitted by: tcberner Added: head/audio/mixxx/files/patch-src_widget_wdisplay.cpp (contents, props changed) Added: head/audio/mixxx/files/patch-src_widget_wdisplay.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/audio/mixxx/files/patch-src_widget_wdisplay.cpp Wed Feb 1 05:25:29 2017 (r432970) @@ -0,0 +1,13 @@ +Fix bogus pointer comparison. + +--- src/widget/wdisplay.cpp.orig 2013-05-08 23:20:26 UTC ++++ src/widget/wdisplay.cpp +@@ -86,7 +86,7 @@ void WDisplay::setPixmap(int iPos, const + + void WDisplay::paintEvent(QPaintEvent *) + { +- if (m_pPixmaps>0) ++ if (m_pPixmaps) + { + int idx = (int)(m_fValue*(float)(m_iNoPos)/128.); + // Range check