Date: Mon, 5 Jul 2010 09:47:32 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Emanuel Haupt <ehaupt@FreeBSD.org> Cc: Anonymous <swell.k@gmail.com>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/audio/xmp Makefile Message-ID: <20100705094732.GA66789@FreeBSD.org> In-Reply-To: <20100705095019.1b16a029.ehaupt@FreeBSD.org> References: <201007010647.o616lMdP059532__40956.557825166$1277966864$gmane$org@repoman.freebsd.org> <86iq4uxvzp.fsf@gmail.com> <20100705090015.0e97934e.ehaupt@FreeBSD.org> <20100705072144.GA47205@FreeBSD.org> <20100705095019.1b16a029.ehaupt@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 05, 2010 at 09:50:19AM +0200, Emanuel Haupt wrote: > Alexey Dokuchaev <danfe@FreeBSD.ORG> wrote: > > On Mon, Jul 05, 2010 at 09:00:15AM +0200, Emanuel Haupt wrote: > > > Anonymous <swell.k@gmail.com> wrote: > > > > Emanuel Haupt <ehaupt@FreeBSD.org> writes: > > > > > > > > > ehaupt 2010-07-01 06:47:22 UTC > > > > > > > > > > FreeBSD ports repository > > > > > > > > > > Modified files: > > > > > audio/xmp Makefile > > > > > Log: > > > > > Prevent unconditional linking against ALSA > > > > > > > > Hmm, and why you untabified ALSA option? > > > > > > > > It's inconsistent with other options. Turn on whitespace-mode (in > > > > emacs) and see for yourself. > > > > > > Good catch, it's due to a copy pasta [1] glicht. I'll fix it in the > > > upcoming release. > > > > These are pretty easy to avoid, just do "grep ' ' *" and "grep ' $' > > *" in the port directory before committing (like I always do, in > > addition to portlint(1)). > > Portlint wouldn't have cought it, since the spaces were here: I did not say portlint(1) would have caught it. > OPTIONS= ALSA "ALSA output driver" off \ > > I and many others often use spaces in that part of the options section. > In this case it just wasn't consistent with the other options, which is > due to copy pasting. I understand. My point that simple "grep ' ' *" would help to identify places with two (or more) adjacent spaces. Sometimes they are intentional and useful (after full stops, padding where tabs are not enough), but often they are bogus. The latter ones should be fixed. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100705094732.GA66789>