Date: Wed, 28 Feb 2018 11:16:41 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Tobias C. Berner" <tcberner@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r463193 - head/lang/hugs Message-ID: <20180228111641.GA3235@FreeBSD.org> In-Reply-To: <201802281053.w1SArquo038775@repo.freebsd.org> References: <201802281053.w1SArquo038775@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 28, 2018 at 10:53:52AM +0000, Tobias C. Berner wrote: > New Revision: 463193 > URL: https://svnweb.freebsd.org/changeset/ports/463193 > > Log: > devel/hugs: workaround to fix build on current > > runhugs binary crashes when compiled with -O2 on i386 12-CURRENT system. > Workaround it by compiling with -O0 I can see two issues with this commit: 1) observed breakage not documented well enough (detailed analysis is not required, but at least file/module/function name would be nice to know); 2) optimizations are disabled for entire source, while perhaps it would be better to limit this workaround to problematic file(s) only; I've recently had encountered and fixed similar problem, cf. r457598. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180228111641.GA3235>