From owner-svn-ports-all@freebsd.org  Wed Feb 28 11:16:42 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FCAFF3EC27;
 Wed, 28 Feb 2018 11:16:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1319471E92;
 Wed, 28 Feb 2018 11:16:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 03BDDEA46; Wed, 28 Feb 2018 11:16:41 +0000 (UTC)
Date: Wed, 28 Feb 2018 11:16:41 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "Tobias C. Berner" <tcberner@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r463193 - head/lang/hugs
Message-ID: <20180228111641.GA3235@FreeBSD.org>
References: <201802281053.w1SArquo038775@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201802281053.w1SArquo038775@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Feb 2018 11:16:42 -0000

On Wed, Feb 28, 2018 at 10:53:52AM +0000, Tobias C. Berner wrote:
> New Revision: 463193
> URL: https://svnweb.freebsd.org/changeset/ports/463193
> 
> Log:
>   devel/hugs: workaround to fix build on current
>   
>   runhugs binary crashes when compiled with -O2 on i386 12-CURRENT system.
>   Workaround it by compiling with -O0

I can see two issues with this commit:

1) observed breakage not documented well enough (detailed analysis is not
required, but at least file/module/function name would be nice to know);

2) optimizations are disabled for entire source, while perhaps it would
be better to limit this workaround to problematic file(s) only; I've
recently had encountered and fixed similar problem, cf. r457598.

./danfe