From owner-p4-projects@FreeBSD.ORG Sat Feb 2 22:27:14 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 110B116A41B; Sat, 2 Feb 2008 22:27:14 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B285C16A417 for ; Sat, 2 Feb 2008 22:27:13 +0000 (UTC) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id A2FA713C46A for ; Sat, 2 Feb 2008 22:27:13 +0000 (UTC) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m12MRDEF082204 for ; Sat, 2 Feb 2008 22:27:13 GMT (envelope-from jb@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m12MRDQt082201 for perforce@freebsd.org; Sat, 2 Feb 2008 22:27:13 GMT (envelope-from jb@freebsd.org) Date: Sat, 2 Feb 2008 22:27:13 GMT Message-Id: <200802022227.m12MRDQt082201@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to jb@freebsd.org using -f From: John Birrell To: Perforce Change Reviews Cc: Subject: PERFORCE change 134677 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2008 22:27:14 -0000 http://perforce.freebsd.org/chv.cgi?CH=134677 Change 134677 by jb@jb_freebsd1 on 2008/02/02 22:27:05 I prefer to have the probe arguments to a syscall return probe match the entry probe. This avoids having to probe and entry call and save stuff in local variables for use in the return probe. The error variable is saved in the thread structure anyway (and is on Solaris too -- the DTrace test suite checks that), so it doesn't been to be passed in as the return probe arguments when there are more useful things to pass. Affected files ... .. //depot/projects/dtrace/src/sys/amd64/amd64/trap.c#22 edit .. //depot/projects/dtrace/src/sys/i386/i386/trap.c#27 edit .. //depot/projects/dtrace7/src/sys/amd64/amd64/trap.c#5 edit Differences ... ==== //depot/projects/dtrace/src/sys/amd64/amd64/trap.c#22 (text+ko) ==== @@ -903,10 +903,6 @@ td->td_errno = error; #ifdef KDTRACE_HOOKS - /* Save the error return variable for DTrace to reference. */ - args[0] = error; - args[1] = error; - /* * If the systrace module has registered it's probe * callback and if there is a probe active for the ==== //depot/projects/dtrace/src/sys/i386/i386/trap.c#27 (text+ko) ==== @@ -1086,10 +1086,6 @@ td->td_errno = error; #ifdef KDTRACE_HOOKS - /* Save the error return variable for DTrace to reference. */ - args[0] = error; - args[1] = error; - /* * If the systrace module has registered it's probe * callback and if there is a probe active for the ==== //depot/projects/dtrace7/src/sys/amd64/amd64/trap.c#5 (text+ko) ==== @@ -903,10 +903,6 @@ td->td_errno = error; #ifdef KDTRACE_HOOKS - /* Save the error return variable for DTrace to reference. */ - args[0] = error; - args[1] = error; - /* * If the systrace module has registered it's probe * callback and if there is a probe active for the