From owner-svn-src-head@freebsd.org Thu Feb 22 16:22:04 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01E34F1399F; Thu, 22 Feb 2018 16:22:04 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x22b.google.com (mail-lf0-x22b.google.com [IPv6:2a00:1450:4010:c07::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 60B9B6B92A; Thu, 22 Feb 2018 16:22:03 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x22b.google.com with SMTP id m69so8197340lfe.8; Thu, 22 Feb 2018 08:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=1nxet3W0oHKQ8yHgH3Tpmaz33IjyCBVgoX0AqYrXEns=; b=syI2mN2ZDNeZTu2f4v/rWyWuA+kyGNViOX/0Indk5ycFl9qgJCtouSq22u4Pqx8/MQ KqB0V1kqQMnp4NmJptNTI8KBJYHNHHwg21Ry24pgBq9E9qN+44HDd8kloBLqlt08zFAJ mrZw6sIb4DN3jah55GqDWrmFGqD+FraU13J577UgpBre/KYNBbz5IDrDOfnwv8drxRl2 CePw5XEb6cGJzD59t9F8cyNySAUsgi73qWInRMCpT5TIyTzHwOy0weDy5keyAdsjN6es o7R8TWGVtIP2j9rUTliUcWQ+u9afXJzzHgUWLk56yPwHQ7qslR8g/4QB8exBSU1KRq// XStg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=1nxet3W0oHKQ8yHgH3Tpmaz33IjyCBVgoX0AqYrXEns=; b=n3rvd2KymzL7MME2ls/Th1YoVE+ZxtEeHdligyX/OwH7vvfa43GZQRMba3sTN27lHP 2KViIMo4HkSnqGBz3l3XAuVqqz0IbJ63QkIpyMT0/BRwAil5ECgxXIJKwg2kdE690usZ Rnsjr3QZPB45cfEg41haGK9fC16dwdS6N/aYEnMNGbq3QeXP/1WxT13mo4BktwV9ad6K 1KKcQKGPWEaWl2iCp7/P+5yGDtMxf39BchHihQNSXh1HWzdDsZi8B085vbB0HXADBm/w meqUKXjveTqBbB0dRBKYQALLpXSsfmszcdBaci8ql3nWZGnb6dJ2dZvM2JnTF7hXQb3d 8DYw== X-Gm-Message-State: APf1xPCVWd3VwJb4v51coXEG7hurbwIP4Hh+tPltrMgEYWLX5wsp1SgL n3DpnMX4rXJL42qednA1rd9LBr8Vc0l6/aa11NKMFQ== X-Google-Smtp-Source: AH8x226x5BYHDe+4L2uaQhO3fhGmlqpjnnIvlsm5NTMOkog7uirfNLWucKAavk0hXkEUu8JK9foMYG4K+SJYxtvJBuA= X-Received: by 10.25.157.80 with SMTP id g77mr5299579lfe.142.1519316521724; Thu, 22 Feb 2018 08:22:01 -0800 (PST) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.30.66 with HTTP; Thu, 22 Feb 2018 08:22:01 -0800 (PST) In-Reply-To: References: <201802221332.w1MDWVao004564@repo.freebsd.org> From: Alan Somers Date: Thu, 22 Feb 2018 09:22:01 -0700 X-Google-Sender-Auth: 0iSKhGe554WIULJyqzNsDsk04cs Message-ID: Subject: Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme To: Kyle Evans Cc: Wojciech Macek , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 16:22:04 -0000 On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: > On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers wrote: > > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek wrote: > > > >> Author: wma > >> Date: Thu Feb 22 13:32:31 2018 > >> New Revision: 329824 > >> URL: https://svnweb.freebsd.org/changeset/base/329824 > >> > >> Log: > >> NVMe: Add big-endian support > >> > >> Remove bitfields from defined structures as they are not portable. > >> Instead use shift and mask macros in the driver and nvmecontrol > >> application. > >> > >> NVMe is now working on powerpc64 host. > >> > >> Submitted by: Michal Stanek > >> Obtained from: Semihalf > >> Reviewed by: imp, wma > >> Sponsored by: IBM, QCM Technologies > >> Differential revision: https://reviews.freebsd.org/D13916 > >> > > > > It looks like this change broke the build with Clang: > > > > Fixed in r329827... all little endian arch's broken, not so great. =( > Fast work, Kyle. Thanks a bundle. -Alan