Date: Thu, 24 Aug 2017 14:12:32 +0200 From: Thierry Thomas <thierry@FreeBSD.org> To: Romain =?iso-8859-1?Q?Tarti=E8re?= <romain@FreeBSD.org> Cc: Baptiste Daroussin <bapt@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, sobomax@FreeBSD.org Subject: Re: svn commit: r448610 - in head/devel/leatherman: . files Message-ID: <20170824121232.GA31945@graf.pompo.net> In-Reply-To: <20170823140836.GB13824@blogreen.org> References: <201708231317.v7NDHEGS099253@repo.freebsd.org> <20170823132505.s7kakyqgyb5tdy42@ivaldir.net> <20170823134551.GA13824@blogreen.org> <20170823134934.rjje72qwomm7sd6c@ivaldir.net> <20170823140836.GB13824@blogreen.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--LZvS9be/3tNcYl/X Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Le mer. 23 ao=FBt 17 =E0 16:08:36 +0200, Romain Tarti=E8re <romain@FreeBSD.= org> =E9crivait=A0: > Another point with `make makepatch`: in the post-patch target, I alter > the patched source code. `make makepatch` wants the combined patches to > be combined: >=20 > ---------------------------------- 8< ---------------------------------- > -+ return "%%PREFIX%%/etc/facter/facter.conf"; > ++ return "/usr/local/etc/facter/facter.conf"; > ---------------------------------- 8< ---------------------------------- This is why this kind of substitutions are better in pre-configure. Logically, post-patch is for static replacements, not for variables depending on the configuration options. --=20 Th. Thomas. --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJZnsKwXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFNTM2QkU4NTM4NTM5OUQwMEI2RkFBNzZG MUM1MTZCM0M4MzU5NzUzAAoJEPHFFrPINZdTz1EP/0dp/IF69cPOZHViEj6PlhJb mr1iie4haQSVsBmHVJpBNPUzvii9I2SYh1W5BfeWf1s9AfLtgJKfYIjsQMXuxghP ahYkwlKeVur81TmzsRvaR6SCKQjc7Sa3yGDI5/G8z2YN5xlmDiTKs1NGR5iweVem w52z/LNnEDP0tQJnKfGMmnWe/Y+AIEnYVe3m06qLt3RUB+7vNX2QEr6Zk8AhKggR 4NH5D91QewKSDuiN5uAE1qSCIhYi34ZcwHWGhRzJcS5Vo41fzAu+LeUeDy9PZs4r KLg9zSVeYnbkptbpTfplp29MemyUXu15NCfDlWDVNsCliXwEOwAM4L6gCCTdVlx0 gVsccXWwnZ9AkK6ToYzqQwbCXjENVC7creKedkC3xEXKT+J673y5Mj3MohHionex NiaF9ub9WNVm4bAS5EhKdAndVajaCD6i5k0xbOn9J2xZ8PidjuRjPZAARxrb8MtI 7uc7fj8sP8C6YGwzVl0kXUxvxQiKDnN8GRl2iqbnTjQ3UTleSf2NSEThaAK8WoIe PjcP9daVTVUgiR12tD20Pa80zGxtiH8V7qHgNCrGNGEYy0eQtWEvH8jtptDaH7MT XUL32orvuBQg93rvbTrVBGQnKOytG4uDOOzVlk16L3YZq52hK2vk8CE7o43S8ujG rj/ScpKSqy9XYe5KS3Ss =BU7n -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170824121232.GA31945>