From owner-freebsd-current Sat May 29 3:21:44 1999 Delivered-To: freebsd-current@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id AB6EE1545D; Sat, 29 May 1999 03:21:40 -0700 (PDT) (envelope-from des@flood.ping.uio.no) Received: (from des@localhost) by flood.ping.uio.no (8.9.3/8.9.1) id MAA11860; Sat, 29 May 1999 12:21:34 +0200 (CEST) (envelope-from des) To: "Jordan K. Hubbard" Cc: Dag-Erling Smorgrav , asami@FreeBSD.ORG (Satoshi - Ports Wraith - Asami), junkmale@xtra.co.nz, current@FreeBSD.ORG Subject: Re: FTP passive mode - a new default? References: <17703.927941034@zippy.cdrom.com> From: Dag-Erling Smorgrav Date: 29 May 1999 12:21:33 +0200 In-Reply-To: "Jordan K. Hubbard"'s message of "Fri, 28 May 1999 18:23:54 -0700" Message-ID: Lines: 30 X-Mailer: Gnus v5.5/Emacs 19.34 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG "Jordan K. Hubbard" writes: > My only point was that you should make sure something is a certain way > before you offer advice for dealing with its *current* behavior since, > otherwise, that's just confusing to everyone. Either way, I don't > think that *any* of the current sources, from libfetch to libftpio, > are currently doing anything "right" with FTP_PASSIVE_MODE and hence > this debate is also 100% academic for the time being. :-) So let's *make* them Do The Right Thing. That's what commit privs are for, after all. des@des ~$ stable FTP_PASSIVE_MODE src/lib/libfetch/ftp.c: #define FTP_PASSIVE_MODE 227 src/lib/libfetch/ftp.c: if ((e = _ftp_cmd(cf, "PASV" ENDL)) != FTP_PASSIVE_MODE) src/lib/libftpio/ftpio.3: .Bl -tag -width FTP_PASSIVE_MODE -offset 123 src/lib/libftpio/ftpio.3: .It Ev FTP_PASSIVE_MODE src/lib/libftpio/ftpio.c: if (getenv("FTP_PASSIVE_MODE")) src/usr.bin/fetch/fetch.1: .Bl -tag -width FTP_PASSIVE_MODE -offset indent src/usr.bin/fetch/fetch.1: .It Ev FTP_PASSIVE_MODE src/usr.bin/ftp/ftp.1: .Bl -tag -width "FTP_PASSIVE_MODE" src/usr.bin/ftp/ftp.1: .It Ev FTP_PASSIVE_MODE src/usr.bin/ftp/main.c: if (getenv("FTP_PASSIVE_MODE") || strcmp(cp, "pftp") == 0) src/usr.sbin/pkg_install/add/pkg_add.1: FTP_PASSIVE_MODE Looks like ftpio(3) and ftp(1) both Do The Wrong Thing. Should be trivial to fix, but I have a train to catch right now :) DES -- Dag-Erling Smorgrav - des@flood.ping.uio.no To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message