From owner-svn-src-all@freebsd.org Fri Sep 15 21:31:13 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36C31E0B778; Fri, 15 Sep 2017 21:31:13 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EA1307E69B; Fri, 15 Sep 2017 21:31:12 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 89B2F20BD8; Fri, 15 Sep 2017 17:31:10 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Fri, 15 Sep 2017 17:31:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsco.org; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=qnN3F6dL9F7Ac4IS4D TZeR2XG3/V1RBHmV2hQYvg67w=; b=Ky4nwUcFk6tm1wFVUwk1rPJniord9q+Z+A mfzp2wo2DVw0G1jX8cwf82UI5E3aAnglfNM0eyLARuv10uOQVOvMpdSqjh6RVXJ6 7qEEj245cm8mfi+xHeBjBGzlssUebQB5ZzjSD0GaXtDt6hXYvDGVkpTgaPObhKXl P0WP2+mL6x9z33lag89bDJngvxAtdnnTZk2qiET46hVg0QRFTx0imf/4KVBFObIi il5HGxHMJrvnzvVBBbbjj5D+mrZZSm8dQe19Ylm0+t7wqxaRBpzVI2hT9g4fkK2o 20HqJCzKAW76myhQT4r/XIkHIu16p9r4MP2jTi0fD/l+GKWSySMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=qnN3F6dL9F7Ac4IS4DTZeR2XG3/V1RBHmV2hQYvg67w=; b=mJAiOVdJ sqkXJcxeWKjB10lcqbLozczQHCw56vx/tEfswHqE8BkFikdAR6hka4PxDOgG/8Nf DQhqKRdXy7Vh8DsQlGoXFeEXcqQ/lfY4BIm0HElJYGFZTQGaFwL8DO637zlgLmW4 DZXYRwUvc4wpAFUm/dMvJovLvDfzM9dHnJSUWQOeHM7jk6lO2o3kdZQ51qsTiqL5 yeWIlzq408q58+Hdcy6+WC+I5it46EpTWqguM9dkbkZWIliWIRyovV0JeWwzl4hf YgjYQtkF7tUmdKe0RpdPmm/7Us6O2dzyQSzowCOrL7tf6OGEMoGZHe/vH72CXT05 hoV6nqhOHR3A5w== X-ME-Sender: X-Sasl-enc: 3jOBROD6xFXshRT2t6nZjho11bgZysd9Ixj65o93PwP2 1505511070 Received: from [192.168.0.117] (unknown [161.97.249.191]) by mail.messagingengine.com (Postfix) with ESMTPA id BBCDF7F955; Fri, 15 Sep 2017 17:31:09 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r323516 - in head/sys: dev/bnxt dev/e1000 kern net sys From: Scott Long In-Reply-To: <48654d1f-4cc7-da05-7a73-ef538b431560@freebsd.org> Date: Fri, 15 Sep 2017 15:31:07 -0600 Cc: Cy Schubert , Ngie Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <1EBD0641-002D-409C-B18E-AAB5FCDECEBA@samsco.org> References: <201709130711.v8D7BlTS003204@slippy.cwsent.com> <48654d1f-4cc7-da05-7a73-ef538b431560@freebsd.org> To: Sean Bruno , Stephen Hurd X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 21:31:13 -0000 > On Sep 13, 2017, at 9:12 AM, Sean Bruno wrote: >=20 >>>> #blamebruno >>>>=20 >>>> Reviewed by: sbruno >>>> Approved by: sbruno (mentor) >>>> Sponsored by: Limelight Networks >>>> Differential Revision: https://reviews.freebsd.org/D12235 >>>=20 >>> *gasps at the LoC count and number of changed drivers* >>>=20 >>> Could someone please better break this up in the future..? >>=20 >> Agreed. Down the road parsing out individual commits in this jumbo = commit=20 >> will be difficult to parse. IMO this may as well have simply been, = import=20 >> from https://github.com/mattmacy/networking/, just like Mr. Torvalds = does=20 >> at kernel.org. I expect to see a commit like this there but not here. = Can=20 >> we break this down to its functional commits? >>=20 >>=20 >=20 >=20 > This ridiculous loc was due to the amount of restructuring needed to = get > us back to being in sync with our development. The future will not = have > this big of a commit/change and should be more bite/fun sized. >=20 > The #blamebruno tag in the commit log was to indicate that this was = not > something Stephen was doing on his own, but was something that I had > induced over the last few months during testing. >=20 This breaks my system. I prior to this commit, I had igb0 and igb1. = Now I only have igb0, and it=E2=80=99s like igb1 isn=E2=80=99t even trying to = attach. Unfortunately, this breaks my nfsroot setup, so I need to roll back my tree. Please = let me know if there=E2=80=99s anything I can provide to help debugging. Scott