From owner-svn-ports-all@freebsd.org Thu Dec 3 07:53:51 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDAFCA3F275; Thu, 3 Dec 2015 07:53:51 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 912EE1AC8; Thu, 3 Dec 2015 07:53:50 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.1.22] (253.Red-83-32-1.dynamicIP.rima-tde.net [83.32.1.253]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id A379B43C01; Thu, 3 Dec 2015 01:53:47 -0600 (CST) Subject: Re: svn commit: r402813 - head/misc/astrolog To: Alexey Dokuchaev , marino@freebsd.org References: <201512020629.tB26TbDb060296@repo.freebsd.org> <565E9DFA.6050502@marino.st> <565EAB52.6010301@freebsd.org> <565EAD1E.8080805@marino.st> <565EB1AC.4000508@freebsd.org> <565EB3B7.8030208@marino.st> <20151203034439.GB25120@FreeBSD.org> Cc: Andrey Chernov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Reply-To: marino@freebsd.org From: John Marino Message-ID: <565FF508.7030508@marino.st> Date: Thu, 3 Dec 2015 08:53:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20151203034439.GB25120@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2015 07:53:51 -0000 On 12/3/2015 4:44 AM, Alexey Dokuchaev wrote: > On Wed, Dec 02, 2015 at 10:02:47AM +0100, John Marino wrote: >> On 12/2/2015 9:54 AM, Andrey Chernov wrote: >>> 3) Contact the person who does most commits to this port. >> >> I think this is a dream. I don't expect people to sort through the >> history and try to figure out a commit pattern, plus the presence of a >> prior commit doesn't imply a willingness for a future commit. > > Again, this (that checking prior history is a dream) is our problem. > Andrey is totally right here, that's what version control for and that's > what responsible developer does. The fact that lots of us do not care > to go through the history, to an extent of neglecting to properly repo- > copy or move ports, essentially using SVN as kind of FTP, does not mean > that we're doing it correctly. > > So yeah, I'd expect people to sort through the history. If they don't, > they should learn something about collaborative software development > first. For ports committers, it must be a part on their obligatory > introductory course they receive while being mentored. (Again, IMHO we > are not doing good job mentoring people, given the quality of commits.) You're missing the most common case. The case were commit X has detected 20 broken ports and has relatively little time. In that time he can either a) fix one port to these standards and leave 19 untouched and still broken or b) mark then all broken and let others fix them as they are discovered (which is exactly what happened here). A side benefit of b) is that we get ports broken for 6 months and now we have a pool of ports that clearly aren't popular. I'm taking b) every time. You cannot do both (fix well and fix all). You got overwhelmed extremeely quickly on the MAKE_JOBS_UNSAFE fixing; they can faster than you could fix, so you should understand the deluge scenario. John