From owner-freebsd-ports@FreeBSD.ORG  Thu Jul  2 15:58:35 2009
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EA980106564A
	for <freebsd-ports@freebsd.org>; Thu,  2 Jul 2009 15:58:35 +0000 (UTC)
	(envelope-from lstewart@freebsd.org)
Received: from lauren.room52.net (lauren.room52.net [210.50.193.198])
	by mx1.freebsd.org (Postfix) with ESMTP id 7B5828FC15
	for <freebsd-ports@freebsd.org>; Thu,  2 Jul 2009 15:58:35 +0000 (UTC)
	(envelope-from lstewart@freebsd.org)
Received: from lstewart-laptop.caia.swin.edu.au (c149.al.cl.cam.ac.uk
	[128.232.110.149]) (authenticated bits=0)
	by lauren.room52.net (8.14.3/8.14.3) with ESMTP id n62Fw6WD030880
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 3 Jul 2009 01:58:09 +1000 (EST)
	(envelope-from lstewart@freebsd.org)
Message-ID: <4A4CD909.7090400@freebsd.org>
Date: Thu, 02 Jul 2009 16:58:01 +0100
From: Lawrence Stewart <lstewart@freebsd.org>
User-Agent: Thunderbird 2.0.0.22 (X11/20090626)
MIME-Version: 1.0
To: Hans Petter Selasky <hselasky@c2i.net>
References: <200906080902.43391.hselasky@c2i.net>	<4A4CC9C1.4080200@freebsd.org>	<200907021700.39350.hselasky@c2i.net>
	<4A4CCECA.40607@freebsd.org>
In-Reply-To: <4A4CCECA.40607@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL
	autolearn=disabled version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on lauren.room52.net
Cc: mezz7@cox.net, freebsd-ports@freebsd.org, markus@brueffer.de
Subject: Re: Temporary patch to fix USB in kdebase4
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jul 2009 15:58:36 -0000

[trimmed CC list]

Lawrence Stewart wrote:
> Hans Petter Selasky wrote:
>> On Thursday 02 July 2009 16:52:49 Lawrence Stewart wrote:
>>> Hans Petter Selasky wrote:
>>>> See attachment.
>>>> --HPS
>>> Any chance you (or someone with the right clue) could update this patch
>>> to work with more recent 8-CURRENT? I get the following output when
>>> trying to compile kdebase4 (which applies your original patch as
>>> extra-patch-libusb20) on r195046 world/kernel:
>>>
>>>
>>> Scanning dependencies of target kcm_usb
>>>
>>> [ 67%] Building CXX object
>>> apps/kinfocenter/usbview/CMakeFiles/kcm_usb.dir/kcm_usb_automoc.o
>>> [ 67%] Building CXX object
>>> apps/kinfocenter/usbview/CMakeFiles/kcm_usb.dir/kcmusb.o
>>> In file included from
>>> /usr/ports/x11/kdebase4/work/kdebase-4.2.4/apps/kinfocenter/usbview/usbdevi 
>>>
>>> ces.h:20,
>>>
>>>
>>
>> Hi,
>>
>> It looks like you have two set of header files. Second, change the USB 
>> "dev/"  header files to:
>>
>> #  include <dev/usb/usb.h>
>> #  include <dev/usb/usbdi.h>
>>
>> Else there are no further changes.
> 
> ah ha, had forgotten to run "make delete-old" after last update. Thanks 
> for the hint and thanks for the include fix. Trying it out now.


FYI, Hans your suggestion didn't work. Jeremy's on the other hand did. 
By only including <dev/usb/usb_ioctl.h> the compile finishes without issue.

I'm in the process of updating to today's current though and a lot of 
USB related changes were in the changeset so it's entirely possible 
running new kernel/world will make your comments valid.

Cheers,
Lawrence