Date: Sat, 26 Feb 2005 17:15:09 -0800 From: Nate Lawson <nate@root.org> To: Marcel Moolenaar <marcel@FreeBSD.org>, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/powerd powerd.c Message-ID: <42211F1D.30801@root.org> In-Reply-To: <20050227002323.AEFC716A55A@hub.freebsd.org> References: <20050227002323.AEFC716A55A@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar wrote: > marcel 2005-02-27 00:23:19 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/powerd powerd.c > Log: > Unbreak !i386 platforms. Only i386 has APM, so don't try to fallback > on APM on other platforms. > > Revision Changes Path > 1.3 +11 -1 src/usr.sbin/powerd/powerd.c Thanks. It would be cleaner to move this code into apm_init_ac() and acpm_get_ac() functions so the ifdef could be in just one place. I think there is also one other issue. It would be cleaner to check for the acpi sysctl in the rc.d script and return immediately rather than starting powerd and it bombing out once it discovers this. Patches welcome since my rc-familiarity is quite low. -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42211F1D.30801>