From owner-svn-src-all@freebsd.org Wed Mar 1 22:41:24 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BAF19CF3876; Wed, 1 Mar 2017 22:41:24 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qk0-x22a.google.com (mail-qk0-x22a.google.com [IPv6:2607:f8b0:400d:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 75BD6836; Wed, 1 Mar 2017 22:41:24 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qk0-x22a.google.com with SMTP id n186so93162089qkb.3; Wed, 01 Mar 2017 14:41:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/hizwZarKsHXor9AGTSN1XWVQcy1ah3DjsrMKZhDeJw=; b=hjW6w8aWCNFXdVgmqbhvmmQ9Yo2c/m9cPBZyQGS2VQB7R7+GMO6k/lffJaMADKAf+8 U/Aunqabil+2QroUn1moj0t/Ts18z1nM031YOChYl87UrPIWsEXpMcskpglkf1RpogDF 0YQ+qx/tCaqnLbCMOD9oU01fD7uvRc6dWB4OWB1vJov4nSiR9K+RXbEV1Cws87Vb4da2 iko4hv6WdhHr8ohFG02+W/N3YyGm7rNpkvuBWcS8V1WFaXDnToH2PB1tfQL95prJrDBj t93f3WaO4qFMr1ooX1Xd/BPRY62sYz4wx2IRG2QLYQe/7yXyBhohGk1tEyW88d5EWZwR KcVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/hizwZarKsHXor9AGTSN1XWVQcy1ah3DjsrMKZhDeJw=; b=AVnLXBMEfvQo1UEqjqewC5rRH+VncarQr6XH18WNpCsnUQHqxqkw57ahODPx38GEkN EmRVIUFWOF7mu/eu0BRu5nvNKcROLX1zdF7YviMaVrra3DeVpb0RwO7Ge4vjzkd25mel 3BOOEBR373V5j6RA9QDN6s0zfmbjm5L19D30f/Yp1UmzVPwN8pqMo9bVknkBqj8be/8E IgJhSXu+Sy+6re4DzY7b0qtba3S1NNm58+qzrmSOfXxiYfGpzpixK8PKX0e0oGsIqWCB 5dQHuGx5usps+env0HEd/homwnTIDzHFCp3UiMIK+EReK0snZBXJ3QEff5oTgbe6cLAE xlDA== X-Gm-Message-State: AMke39mptZ7C5/JzpL2UbR3HLCNC2LbJvwNyh/6P8fGTEZr5goKq5+NN+0JzXy+dC/rCy0sXNerYsEvbVRp/oQ== X-Received: by 10.55.18.158 with SMTP id 30mr4767081qks.123.1488408083585; Wed, 01 Mar 2017 14:41:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.104.200 with HTTP; Wed, 1 Mar 2017 14:41:23 -0800 (PST) In-Reply-To: <201703011708.v21H89XW057584@pdx.rh.CN85.dnsmgr.net> References: <20170301165916.kuizbr2w5l2beoac@ivaldir.etoilebsd.net> <201703011708.v21H89XW057584@pdx.rh.CN85.dnsmgr.net> From: Ngie Cooper Date: Wed, 1 Mar 2017 14:41:23 -0800 Message-ID: Subject: Re: svn commit: r314464 - head/usr.sbin/yppush To: "Rodney W. Grimes" Cc: Baptiste Daroussin , Alexey Dokuchaev , src-committers , Ian Lepore , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 22:41:24 -0000 On Wed, Mar 1, 2017 at 9:08 AM, Rodney W. Grimes wrote: ... > At one point in history I can promise you that ALL symlinks in the release > where shortest possible relative path. So any absolute links that entered > the system got created by developers who where not aware that they should > always use a relative link for anything landing in DESTDIR. This creates > breakge on so many levels we should make a rapid correction to this > regression. This is why things are that way currently: $ git blame usr.bin/chpass/Makefile| grep ypchfn 780ae7713f72b (gjb 2016-01-28 01:15:57 +0000 29) SYMLINKS+= ${BINDIR}/chpass ${BINDIR}/ypchfn aca2488187113 (wosch 1997-09-13 12:21:25 +0000 35) MLINKS+= chpass.1 ypchpass.1 chpass.1 ypchfn.1 chpass.1 ypchsh.1 5294f47313a2d (gjb 2016-01-28 02:56:30 +0000 39) .for i in chpass chfn chsh ypchpass ypchfn ypchsh $ git log 780ae7713f72b^..780ae7713f72b commit 780ae7713f72b471859c0997295ac0c59695c7b4 Author: gjb Date: Thu Jan 28 01:15:57 2016 +0000 Ensure mtree(8) recognizes chpass(1) is schg. Convert hard links to symbolic links, and remove the 'beforeinstall' and 'afterinstall' chflags(8) execution. Sponsored by: The FreeBSD Foundation Notes: svn path=/projects/release-pkg/; revision=294966 BINDIR evaluates to /usr/sbin/, so /usr/sbin/chpass is symlinked to /usr/sbin/ypchfn . But, there's no reason why the symlink needs to be hardcoded, or even a symlink at all. Hardlinks would achieve the same thing here IMHO, but gjb changed it in r294966 to be symlinks. The point that might be missed is that changing it from absolute paths to relative paths or otherwise, might break other workflows.. I could just as easily mount /lib, /usr/lib, /usr/sbin, etc as nullfs mountpoints and have a working system on a system root where MACHINE != TARGET, but this is all orthogonal to my changing `${.CURDIR}/../../contrib` (e.g. `foo/usr.sbin/yppush/../../contrib`), etc to ${SRCTOP}/contrib` (e.g. `foo/contrib`). Thanks, -Ngie