From owner-svn-src-all@freebsd.org  Thu Jan 25 17:23:02 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B1A2EC0EF1;
 Thu, 25 Jan 2018 17:23:02 +0000 (UTC)
 (envelope-from rb743@hermes.cam.ac.uk)
Received: from ppsw-30.csi.cam.ac.uk (ppsw-30.csi.cam.ac.uk [131.111.8.130])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9E24787B92;
 Thu, 25 Jan 2018 17:23:01 +0000 (UTC)
 (envelope-from rb743@hermes.cam.ac.uk)
X-Cam-AntiVirus: no malware found
X-Cam-ScannerInfo: http://help.uis.cam.ac.uk/email-scanner-virus
Received: from sc1.bsdpad.com ([163.172.212.18]:20582)
 by ppsw-30.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:587)
 with esmtpsa (LOGIN:rb743) (TLSv1:ECDHE-RSA-AES256-SHA:256)
 id 1eelEk-000Tbh-cu (Exim 4.90)
 (return-path <rb743@hermes.cam.ac.uk>); Thu, 25 Jan 2018 17:22:54 +0000
Date: Thu, 25 Jan 2018 17:14:52 +0000
From: Ruslan Bukin <ruslan.bukin@cl.cam.ac.uk>
To: Emmanuel Vadot <manu@bidouilliste.com>
Cc: Ruslan Bukin <br@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r328402 - head/sys/dev/usb/controller
Message-ID: <20180125171452.GA61523@bsdpad.com>
References: <201801251658.w0PGwNcq058492@repo.freebsd.org>
 <20180125181204.bb006fbb3a9bcd4acb4236af@bidouilliste.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180125181204.bb006fbb3a9bcd4acb4236af@bidouilliste.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: "R. Bukin" <rb743@hermes.cam.ac.uk>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jan 2018 17:23:02 -0000

On Thu, Jan 25, 2018 at 06:12:04PM +0100, Emmanuel Vadot wrote:
> > Log:
> >   Add basic driver for Qualcomm USB 2.0 EHCI controller.
> >   This driver relies on system initialization in u-boot.
> >   
> >   Tested on DragonBoard 410c.
> >   
> >   Sponsored by:	DARPA, AFRL
> > 
> > Added:
> >   head/sys/dev/usb/controller/ehci_msm.c   (contents, props changed)
> > 
> 
>  The code looks like the generic-ehci, would it be better to subclass
> generic-ehci to fdt and add qualcomm quirks if necessary ?
> 

Hi Emmanuel

This driver is incomplete currently and requires initialization in u-boot.

Both system clocks and EHCI subsystem, also Qualcomm power management device requires full initialization.
My goal will be to extend this driver and proceed full initialization required for Qualcomm EHCI.

The u-boot option CONFIG_DM_DEVICE_REMOVE=n must be added in order to keep devices initialized before jumping to FreeBSD. We will need to get rid of these by adding some code to this driver I guess.

Thanks.

Ruslan