From owner-svn-ports-head@freebsd.org  Wed Jan 30 11:09:59 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9461414BBE21;
 Wed, 30 Jan 2019 11:09:59 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1D16B8C894;
 Wed, 30 Jan 2019 11:09:59 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 0C85F36BF; Wed, 30 Jan 2019 11:09:59 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Stefan Esser <se@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r491618 - in head/net: . timed
References: <201901301046.x0UAkO4M047694@repo.freebsd.org>
Date: Wed, 30 Jan 2019 12:09:45 +0100
In-Reply-To: <201901301046.x0UAkO4M047694@repo.freebsd.org> (Stefan Esser's
 message of "Wed, 30 Jan 2019 10:46:24 +0000 (UTC)")
Message-ID: <va26-2yh2-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Rspamd-Queue-Id: 1D16B8C894
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.94 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.99)[-0.988,0];
 NEURAL_HAM_LONG(-1.00)[-0.996,0];
 NEURAL_HAM_SHORT(-0.95)[-0.954,0];
 ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jan 2019 11:09:59 -0000

Stefan Esser <se@FreeBSD.org> writes:

> +		${INSTALL_DATA} ${WRKSRC}/rc.d/timed \
> +			${STAGEDIR}${PREFIX}/etc/rc.d/

${INSTALL_DATA} unlike ${INSTALL_SCRIPT} strips executable bit. Are you sure?

$ make install
$ service timed onestart
timed does not exist in /etc/rc.d or the local startup
directories (/usr/local/etc/rc.d), or is not executable

> +@mode 4555
> +sbin/timedc

Looks unsafe as something may append ${TMPPLIST}, inheriting setuid bit.
Consider adding @mode at the end or converting to @(,,4555) sbin/timedc