Date: Wed, 14 Mar 2018 22:43:47 +0000 From: Brooks Davis <brooks@one-eyed-alien.net> To: sobomax@freebsd.org Cc: freebsd-current@freebsd.org Subject: md(4) ioctl ABI broken by r322969 Message-ID: <20180314224347.GA46152@spindle.one-eyed-alien.net>
next in thread | raw e-mail | index | archive | help
--0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, I just noticed that r322969 consumed part of md_pad in struct md_ioctl. In moving the start of md_pad this broke the ABI of MDIOCLIST. At a glance it looks like the struct was sufficiently incompetently padded to begin with that the change of adding a char * and subtracting an int did not change the size of the struct and break all the ioctls, but this definitely warranted a comment in the commit. At this point I'm not sure what the right thing to do is. MDIOCLIST isn't used by anything in the base system and is broken by design so just deleting it might be acceptable. A somewhat better approach would be to delete it from public view and fix it up with a compatibility shim so it works for old code. We could put that under COMPAT11. I have a patch it the works that would make that easier to do. -- Brooks --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJaqaWiAAoJEKzQXbSebgfAcnoH/Rsr7w96fpyiDTBwg8yOnNDv UBVdbjMuDorL0qbfkW0uQcXXyU1voVjFKwTMxyrEDNu84VdpwG9NrEn+wiB3HcI+ Ui6JI4YWENF4Ld+1aR6pqhgsr0kOMET+EkNdkid/X03Z8JAeyQfomZ5QN/WmmAE9 Fp5roHqbxJg2i1bo0xoRIVCEcBtn4Foe+hk2Mx/PEgIhXOQH+GYod4KGHzeOgGmF QzorryY/8DG1B/9gMTljzNwExtpdwWdtIeejoFWz4/ijEGaVk0xfcdRV0QoD4g7K 2jQmeV86tiSCQjMAQAH0bahR/jLLt0KhsHVNBuLJCIW7EWB29npzCqUfueAkkzs= =di4n -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180314224347.GA46152>