From owner-cvs-usrsbin Sun May 7 09:05:23 1995 Return-Path: cvs-usrsbin-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id JAA24628 for cvs-usrsbin-outgoing; Sun, 7 May 1995 09:05:23 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id JAA24605 ; Sun, 7 May 1995 09:04:23 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id DAA12315; Sun, 7 May 1995 03:03:54 -0700 From: "Rodney W. Grimes" Message-Id: <199505071003.DAA12315@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/usr.sbin/edquota edquota.c To: bde@freefall.cdrom.com (Bruce Evans) Date: Sun, 7 May 1995 03:03:54 -0700 (PDT) Cc: CVS-commiters@freefall.cdrom.com, cvs-usrsbin@freefall.cdrom.com In-Reply-To: <199505070748.AAA09307@freefall.cdrom.com> from "Bruce Evans" at May 7, 95 00:48:38 am X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 1038 Sender: cvs-usrsbin-owner@freebsd.org Precedence: bulk > > bde 95/05/07 00:48:37 > > Modified: usr.sbin/edquota edquota.c > Log: > Cast some expressions involving dbtob() to (unsigned long) and print them > using %lu. This became more broken when I fixed dbtob() to support byte > offsets >= 4GB. The type had to change to [u]quad_t. Previously the > expressions had type unsigned long and were printed using %d. After > division by 1024, the expressions are guaranteed to fit in an unsigned > long, at least for the standard DEV_BSIZE, so edquota doesn't need to > know about quad_t's explicitly. > > Fix all the other format mismatches exposed by compiling with -Wformat > (6 more quota limits of type unsigned long printed using %d and 6 time_t's > (i.e., longs) printed using %d). I'll try to make a pass over the whole tree with a -Wformat and see if it is a manageable task to go fix. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Custom computers for FreeBSD