From owner-svn-ports-all@freebsd.org Tue Jan 8 18:45:03 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 188001486B81; Tue, 8 Jan 2019 18:45:03 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7DB8B71C2E; Tue, 8 Jan 2019 18:45:02 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [192.168.0.101] (97-123-6-172.albq.qwest.net [97.123.6.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 8D9021AFCF8; Tue, 8 Jan 2019 11:43:42 +0000 (UTC) Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest To: Tobias Kortkamp Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> <20190103232315.GA10712@urd.tobik.me> From: Sean Bruno Openpgp: preference=signencrypt Autocrypt: addr=sbruno@freebsd.org; prefer-encrypt=mutual; keydata= mQENBFk+0UEBCADaf4bgxxKvMOhRV5NPoGWRCCGm49d6+1VFNlQ77WsY/+Zvf95TPULdRlnG w648KfxWt7+O3kdKhdRwnqlXWC7zA2Qt0dRE1yIqOGJ4jp4INvp/bcxWzgr0aoKOjrlnfxRV bh+s0rzdZt6TsNL3cVYxkC8oezjaUkHdW4mFJU249U1QJogkF8g0FeKNfEcjEkwJNX6lQJH+ EzCWT0NCk6J+Xyo+zOOljxPp1OUfdvZi3ulkU/qTZstGVWxFVsP8xQklV/y3AFcbIYx6iGJ4 5L7WuB0IWhO7Z4yHENr8wFaNYwpod9i4egX2BugbrM8pOfhN2/qqdeG1L5LMtXw3yyAhABEB AAG0N1NlYW4gQnJ1bm8gKEZyZWVCU0QgRGV2ZWxvcGVyIEtleSkgPHNicnVub0BmcmVlYnNk Lm9yZz6JAVQEEwEKAD4WIQToxOn4gDUE4eP0ujS95PX+ibX8tgUCWT7RQQIbAwUJBaOagAUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAAKCRC95PX+ibX8ttKTCACFKzRc56EBAlVotq02EjZP SfX+unlk6AuPBzShxqRxeK+bGYVCigrYd1M8nnskv0dEiZ5iYeND9HIxbpEyopqgpVTibA7w gBXaZ7SOEhNX1wXwg14JrralfSmPFMYni+sWegPMX/zwfAsn1z4mG1Nn44Xqo3o7CfpkMPy6 M5Bow2IDzIhEYISLR+urxs74/aHU35PLtBSDtu18914SEMDdva27MARN8mbeCDbuJVfGCPWy YHuy2t+9u2Zn5Dd+t3sBXLM9gpeaMm+4x6TNPpESygbVdh4tDdjVZ9DK/bWFg0kMgfZoaq6J l0jNsQXrZV3bzYNFbVw04pFcvA2GIJ7xuQENBFk+0UEBCADIXBmQOaKMHGbc9vwjhV4Oj5aZ DdhNedn12FVeTdOXJvuTOusgxS29lla0RenHGDsgD08UiFpasBXWq/E+BhQ19d+iRbLLR17O KKc1ZGefoVbLARLXD68J5j4XAyK+6k2KqBLlqzAEpHTzsksM9naARkVXiEVcrt6ciw0FSm8n kuK3gDKKe93XfzfP+TQdbvvzJc7Fa+appLbXz61TM1aikaQlda8bWubDegwXbuoJdB34xU1m yjr/N4o+raL0x7QrzdH+wwgrTTo+H4S2c1972Skt5K5tbxLowfHicRl23V8itVQr3sBtlX4+ 66q+Apm7+R36bUS/k+G45Sp6iPpxABEBAAGJATwEGAEKACYWIQToxOn4gDUE4eP0ujS95PX+ ibX8tgUCWT7RQQIbDAUJBaOagAAKCRC95PX+ibX8trrIB/9Pljqt/JGamD9tx4dOVmxSyFg9 z2xzgklTLuDgS73MM120mM7ao9AQUeWiSle/H0UCK7xPOzC/aeUC4oygDQKAfkkNbCNTo3+A qDjBRA8qx0e9a/QjDL+RFgD4L5kLT4tToY8T8HaBp8h03LBfk510IaI8oL/Jg7vpM3PDtJMW tUi2H+yNFmL3NfM2oBToWKLFsoP54f/eeeImrNnrlLjLHPzqS+/9apgYqX2Jwiv3tHBc4FTO GuY8VvF7BpixJs8Pc2RUuCfSyodrp1YG1kRGlXAH0cqwwr0Zmk4+7dZvtVQMCl6kS6q1+84q JwtItxS2eXSEA4NO0sQ3BXUywANh Message-ID: <0a880448-8ef7-76ff-e531-929dbce9ccf3@freebsd.org> Date: Tue, 8 Jan 2019 11:44:57 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ShuzWwyVKw5Cs3lDxPHdzYE7z9UF2sIPQ" X-Rspamd-Queue-Id: 7DB8B71C2E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.957,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2019 18:45:03 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ShuzWwyVKw5Cs3lDxPHdzYE7z9UF2sIPQ Content-Type: multipart/mixed; boundary="4xt8yImpwj1fMx0fi9qIC73wTssaMl3Zs"; protected-headers="v1" From: Sean Bruno To: Tobias Kortkamp Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <0a880448-8ef7-76ff-e531-929dbce9ccf3@freebsd.org> Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> <20190103232315.GA10712@urd.tobik.me> In-Reply-To: --4xt8yImpwj1fMx0fi9qIC73wTssaMl3Zs Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 1/8/19 10:23 AM, Sean Bruno wrote: >=20 >=20 > On 1/3/19 4:23 PM, Tobias Kortkamp wrote: >>> >>> On 1/3/19 2:54 PM, Tobias Kortkamp wrote: >>>>> +USE_QT=3D buildtools \ >>>> Does clementine-player, a music player, really need qt5-buildtools >>>> at runtime or should this be buildtools_build instead? >>>> >>>>> + concurrent \ >>>>> + core \ >>>>> dbus \ >>>>> gui \ >>>>> imageformats \ >>>>> - qmake_build \ >>>>> linguist_build \ >>>>> - moc_build \ >>>>> network \ >>>>> opengl \ >>>>> - qtestlib \ >>>>> - rcc_build \ >>>>> + qmake_build \ >>>>> + testlib \ >>>> Same here. Does it really need qt5-testlib at runtime? >>>> >>> Probably not? >>> >>> sean >>> >> So I guess they are not needed at runtime. Will you change them >> to build dependencies? >=20 > Yeah, I'll look at it today. Thanks! >=20 > sean >=20 Something like this will solve this runtime/buildtime depend issue? Obviously, I'll buildtime/runtime test it before commit. Index: audio/clementine-player/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- audio/clementine-player/Makefile (revision 489727) +++ audio/clementine-player/Makefile (working copy) @@ -41,7 +41,7 @@ USE_GL=3D gl glew glu USE_XORG=3D x11 -USE_QT=3D buildtools \ +USE_QT=3D buildtools_build \ concurrent \ core \ dbus \ @@ -51,7 +51,7 @@ network \ opengl \ qmake_build \ - testlib \ + testlib_build \ sql \ widgets \ x11extras \ --4xt8yImpwj1fMx0fi9qIC73wTssaMl3Zs-- --ShuzWwyVKw5Cs3lDxPHdzYE7z9UF2sIPQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAlw076lfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LaiXwf/c2D331LJax/vyDQpGxNzYqCZyXlILAfGWcrqaH2l3ChU8h29Er34oF7l Mzabvamc5uwAmKACZTzk2CF8Rf6fDK95m/r+0UPTcqUuueUP9Aig4SvwSZlzhqpG wbsIj/kejNhNR08cWzazQVgn6izcPh30n2B5aQPO/27ElkGaD7MBUmgkfHZN1oet Q5pyY+BanxTZH9qpkrq17eq/ciFUoUKazEt+K1ruuAZW6aPSAow0dg31sdh2ioAl RNAYl/n6lF4WL6Hk+NUVvl3AKxvs0HpKG7mvTxdu28v1rE5Vq8lbmW0H75sm9bu3 aeVVEoidqckYnVpKYhpMAjlT2HRmnQ== =aoGA -----END PGP SIGNATURE----- --ShuzWwyVKw5Cs3lDxPHdzYE7z9UF2sIPQ--