From owner-svn-ports-all@FreeBSD.ORG Thu May 30 17:47:03 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id C192D77C; Thu, 30 May 2013 17:47:03 +0000 (UTC) (envelope-from bf1783@googlemail.com) Received: from mail-ie0-x231.google.com (mail-ie0-x231.google.com [IPv6:2607:f8b0:4001:c03::231]) by mx1.freebsd.org (Postfix) with ESMTP id 71EB297D; Thu, 30 May 2013 17:47:03 +0000 (UTC) Received: by mail-ie0-f177.google.com with SMTP id 9so1339553iec.36 for ; Thu, 30 May 2013 10:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=oAcL3tjEBF7uOrxL5sqzLuQS9DJkLqOATSNBx+KBaOE=; b=QDQpw/jLjfxP9k6HH3Q/v8LQ3FMpNMHyBhKJ1Ucup0CRWVNadc9PMOMvccQl6N+JEZ s8zoxYwcp245B7fwu1K1pRxewCz+0HJ9SwJa7bguTPL0rKw0b7pM61a0BCrCkGkbeMPi xe103u+LM5wLdDVOyDz9VVpoR6smQukjyJw2E4xstU5m5FaZQHvyX5aHCdYW/rP8JbXH AI5E5t92W/ACdZZXS8NCg1aIOuzw09T5i610zQ0W1RoHqH35t7EfGoO5ZxJI3n9iD7+l sy2ySB2fOqHTFPoFiLqQg6k3z4DqCOaetq61go19LWJkKBA9OkxFNKI2bbqYEIw/Y8L6 5tUw== MIME-Version: 1.0 X-Received: by 10.42.95.195 with SMTP id g3mr3523678icn.14.1369936023197; Thu, 30 May 2013 10:47:03 -0700 (PDT) Received: by 10.64.39.201 with HTTP; Thu, 30 May 2013 10:47:03 -0700 (PDT) In-Reply-To: References: <201305291541.r4TFf1PO037359@svn.freebsd.org> Date: Thu, 30 May 2013 13:47:03 -0400 Message-ID: Subject: Re: svn commit: r319380 - head/math/libtommath From: "b.f." To: Eitan Adler Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Martin Wilke X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: bf1783@gmail.com List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 May 2013 17:47:03 -0000 On 5/30/13, Eitan Adler wrote: > On 30 May 2013 03:42, Martin Wilke wrote: >> >> On May 30, 2013, at 5:17 AM, Eitan Adler wrote: >> >>> On 29 May 2013 17:41, Martin Wilke wrote: >>>> Author: miwi >>>> Date: Wed May 29 15:41:00 2013 >>>> New Revision: 319380 >>>> URL: http://svnweb.freebsd.org/changeset/ports/319380 >>>> >>>> Log: >>>> - Disable regression test >>>> >>>> Reported by: pointyhat building 2(D)-02:56:27 >>> >>> This doesn't really explain what happened here. >>> Did the regression test fail? Did the tests fail to build? Are there >>> no regression tests? >>> >>> If the tests failed are they false positives, or do they indicate >>> actual problems (where the port should be marked BROKEN)? >>> >> >> the regression test hangs without timeout thats why i have disable it. >> port it self builds fine no reason to mark it broken. > > Do the hangs indicate failure of the test program or failure of the > actual program? > If the latter it should be marked BROKEN. We don't automatically mark ports as BROKEN if they fail to pass a test -- if we did, a great many more ports would be unavailable, because most ports don't perform perfectly. Often test failures are caused by the conditions in which the tests are run, or are due to problems in the testsuite, or represent uncommon or minor problems that should ultimately be fixed, but don't render the port useless in the meantime. b.