Date: Wed, 14 Mar 2018 13:06:19 +0000 From: Pietro Cerutti <gahr@FreeBSD.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r464480 - head/editors/mp Message-ID: <20180314130619.cboqfsyuifzzchzm@ptrcrt.ch> In-Reply-To: <CAJE75NGffzm1pAmuFTpP-w7CS%2BucRxq6o6GgbQY2a94gV8HACw@mail.gmail.com> References: <201803141001.w2EA1Vo2042681@repo.freebsd.org> <CAJE75NGffzm1pAmuFTpP-w7CS%2BucRxq6o6GgbQY2a94gV8HACw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--6ypmlenl6lvd57g4 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mar 14 18 08:38, Jason E. Hale wrote: >On Wed, Mar 14, 2018 at 6:01 AM, Pietro Cerutti <gahr@freebsd.org> wrote: >> Author: gahr >> Date: Wed Mar 14 10:01:31 2018 >> New Revision: 464480 >> URL: https://svnweb.freebsd.org/changeset/ports/464480 >> >> Log: >> editors/mp: fix build with ncurses from base >> >> Modified: >> head/editors/mp/Makefile >> >> Modified: head/editors/mp/Makefile >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/editors/mp/Makefile Wed Mar 14 09:59:28 2018 (r464479) >> +++ head/editors/mp/Makefile Wed Mar 14 10:01:31 2018 (r464480) >> @@ -50,6 +50,7 @@ GTK3_CONFIGURE_ON=3D --with-gtk=3D3 >> >> NCURSES_USES=3D ncurses >> NCURSES_CONFIGURE_WITH=3D curses >> +NCURSES_CFLAGS=3D -I${NCURSESBASE}/include >> >> QT4_USE=3D qt4=3Dcorelib,gui,moc_build \ >> xorg=3Dx11 >> > >Hmm...what was the build failure? It seemed to build fine in poudriere >before this change. NCURSESINC is already passed through in >CONFIGURE_ENV and I see it in ${WRKSRC}/config.cflags after configure >is run. The failure is at compile time, and it only happens if devel/ncurses is=20 installed - which I think it's why you didn't spot it in poudriere. The problem is not with this port per se, but with the fact that=20 NCURSESINC is set to ${LOCALBASE}/include/ncurses when using ncurses=20 =66rom ports. ncurses.h includes <ncurses/ncurses_dll.h> which it cannot=20 find, as ${LOCALBASE}/include itself is not in the search path. The config.sh check for ncurses fails to compile the sample program with=20 this compile line: cc -O2 -pipe -DLIBICONV_PLUG -fstack-protector -fno-strict-aliasing=20 -I/usr/local/include/ncurses .tmp.c -Wl,--as-needed=20 '-Wl,-rpath=3D/usr/local/lib' -fstack-protector -L/usr/local/lib=20 -lncursesw -o .tmp.o As you see, -I${LOCALBASE}/include is missing, so ncurses.h doesn't find=20 ncurses/ncurses_dll.h. So, the issue is more fundamental within Uses/ncurses.mk or within how=20 the ncurses port installs itself (depends how you see it). This was a quick fix to allow the port to be built. Thanks, --=20 Pietro Cerutti --6ypmlenl6lvd57g4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAlqpHkMuFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII ntoQEAC7wxBG8IWZqYhKJOc0W3FvHhYm15wpI8rLiXYmLimxwy6w0PNg7QdfW56H 3klcL0cN93ekn+NwONVmqrX0rCyGRGgFyANzPZ5I2Mk6HolhC55PNxRBaAl8fTbr 8d/NrHdYkBRHqIu/woKrgAvbuOcIfE4tZvGkS5BK0fxbfUCCZ25TAzj57YyUi0YA sBy9vHtbWH+XyMhjcgu9vodTUHrQDa6FXD2bgfZla6pK6uLga8HEdevPlTHAKocs 3nl2xqGGMoFbQ/u2a/YAAlxhh6NffoP86QBqorkJMtWIx+xKMFeS9S5dqzDzq3St xo6I/ATe4f2wCycVETZ1F3vl6omVUn9ESBKCC9kc5Nr87yQBZNdsbf1ZCdnLHehN vPoiTdAwobhf9368Rcpy99cICTzJgIv4+2NIcZiDqb5UXFT68YTttuZu/JTNtVxj yDkWMJoUm5Y9Fg7JTiJCB5E9WQCw6miolpJ+LqQdgwiAWxiP75p+JnQzCeYWoWa2 78fgEzsMFfk7lj24rdLdSUf1lAWluGvgAuzSP4ZkiDZZ0dt+ABkLYa8/KgOmdw3o K26IOy4FAgglM9dDKPaxMcqPumAAjHrcPiv/mul5yySygRVCBp/sIAmcuXrz5jBV 4hDVGiI8nZ89BkaLvMu41JDCGtgVsiAcFL1VCp0DaaU05Azwzg== =TkbB -----END PGP SIGNATURE----- --6ypmlenl6lvd57g4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180314130619.cboqfsyuifzzchzm>