From owner-svn-src-head@freebsd.org Thu Feb 22 16:50:14 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F7BBF15FAC for ; Thu, 22 Feb 2018 16:50:14 +0000 (UTC) (envelope-from wma@semihalf.com) Received: from mail-qt0-x230.google.com (mail-qt0-x230.google.com [IPv6:2607:f8b0:400d:c0d::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C725A6CEEA for ; Thu, 22 Feb 2018 16:50:13 +0000 (UTC) (envelope-from wma@semihalf.com) Received: by mail-qt0-x230.google.com with SMTP id g14so7088168qti.2 for ; Thu, 22 Feb 2018 08:50:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JQC7+6n7icLWdAt7yhKdboqVLyeJwzxxM5zUprLe0Kk=; b=fSK9Z9hdMIs7rsyXhiccNiRlDdW5rV8zyoLVZJDdbNYr9qmabVRJdKACrg93FfEd9F 4pF5d29ZG0WfS7v5WjQE6k5erFs9+tCJjVkyJUgBtR+AnAIy4apnSZQ/sBGCC9jCzyFQ M+mma/7YBJsbg0Tm7/K0cM5l+25I3nQ5hCGgo0cZSaORy/iiLck7pJ86J2ySUPkahAIx iDKq3r+ouiw7QznPPL6Z8SHtZTklD+2cxzHpQQXwLzj9KXRGLK7nozSSuZpTKTDjyS3K D1NCQnSbUj/DRHU4ZmKHpwz+O6tfCviIHoNjbXk8pKw3JrhV4t31tGPfj6VajpTsqkco TZQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JQC7+6n7icLWdAt7yhKdboqVLyeJwzxxM5zUprLe0Kk=; b=jspg/iVdzgWFxyf7VmqCk1Qp/l74CIeoiiNxi0f4MUELIZFGh/Xx2+vC0mMavt2AxT RDQ3RTXpHAer0Fa6K7IuAU0cEdb7JpVD82TwIIwj5jmIQd4Z2nlPquI2Al1pYJE6wktb RCuslydQz5Yv+xmTLPjZAEcuvgvryfOJx+GcXe537+IIA1KiGs8XYJQ0tLllr8OpPbw0 kP3tvfLIXIwwO/r0LEkt+gNd5wzyzE1c1bM5xape7MFti1ThJKwq6qi3mBuePNxzdS+R RIVO3qjw0SwmTJ2DLujU+aYZMcE2hxSL1ADxVpDCtJrSVL0d/OX8d3wmv7qUkfPSaI/b 1WmQ== X-Gm-Message-State: APf1xPCD5KwyXT4aDRG8IA4OyWsCmSgh6x7uMRidSvYJHy/F2XD6RLDI PAgWbuL901FWyZPocfhrfRO1fKAWk2GPj81ORL5kVA== X-Google-Smtp-Source: AH8x224R0j1gEmPgOEK7C2CeQr3u5QOPbESz0op8LAfR2VD4ABw1QWiOh8ozbuNQvlQygZOOpJa9yqy8qSpoDw6dSNw= X-Received: by 10.237.34.172 with SMTP id p41mr12026086qtc.316.1519318213448; Thu, 22 Feb 2018 08:50:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.56.170 with HTTP; Thu, 22 Feb 2018 08:49:53 -0800 (PST) In-Reply-To: References: <201802221332.w1MDWVao004564@repo.freebsd.org> From: Wojciech Macek Date: Thu, 22 Feb 2018 17:49:53 +0100 Message-ID: Subject: Re: svn commit: r329824 - in head: sbin/nvmecontrol sys/cam/nvme sys/conf sys/dev/mpr sys/dev/nvme To: Warner Losh Cc: Alan Somers , Kyle Evans , Wojciech Macek , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , =?UTF-8?Q?Micha=C5=82_Stanek?= Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 16:50:14 -0000 Yes, I'm doing that right now. So far it seems everything is there, but will confirm to be 100% sure. Warner, I'm very sorry for not waiting for your comments. The review was dead for few days and I thought that all was already said, but maybe should have waited a little longer... Let me know what to do now. If you see any issues, I'll be more than happy to fix them. Also, if you insist, we can revert it, but if no drastic changes are required, I'd prefer to leave it as is and make iterational fixes to this part. Regards, Wojtek wma@ 2018-02-22 17:34 GMT+01:00 Warner Losh : > I know all about losing things during the rebase.... > > I'd be a lot happier if you could confirm that nothing else was lost. It's > a large patch, which makes it impossible for others to do it... It seems > to build, and seems to be working in the light testing I've done this > morning... > > Warner > > > On Thu, Feb 22, 2018 at 9:31 AM, Wojciech Macek wrote: > >> Thanks and sorry for troubles! >> These lines must have got lost somewhere during rebase as we run >> tinderbox with this patch yesterday. >> >> Regards, >> Wojtek >> wma@ >> >> 2018-02-22 17:22 GMT+01:00 Alan Somers : >> >>> On Thu, Feb 22, 2018 at 9:20 AM, Kyle Evans wrote: >>> >>>> On Thu, Feb 22, 2018 at 10:19 AM, Alan Somers >>>> wrote: >>>> > On Thu, Feb 22, 2018 at 6:32 AM, Wojciech Macek >>>> wrote: >>>> > >>>> >> Author: wma >>>> >> Date: Thu Feb 22 13:32:31 2018 >>>> >> New Revision: 329824 >>>> >> URL: https://svnweb.freebsd.org/changeset/base/329824 >>>> >> >>>> >> Log: >>>> >> NVMe: Add big-endian support >>>> >> >>>> >> Remove bitfields from defined structures as they are not portable. >>>> >> Instead use shift and mask macros in the driver and nvmecontrol >>>> >> application. >>>> >> >>>> >> NVMe is now working on powerpc64 host. >>>> >> >>>> >> Submitted by: Michal Stanek >>>> >> Obtained from: Semihalf >>>> >> Reviewed by: imp, wma >>>> >> Sponsored by: IBM, QCM Technologies >>>> >> Differential revision: https://reviews.freebsd.org/D13916 >>>> >> >>>> > >>>> > It looks like this change broke the build with Clang: >>>> > >>>> >>>> Fixed in r329827... all little endian arch's broken, not so great. =( >>>> >>> >>> Fast work, Kyle. Thanks a bundle. >>> -Alan >>> >> >> >