From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Nov 21 06:40:06 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 02F8716A468 for ; Wed, 21 Nov 2007 06:40:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id DD63B13C4E5 for ; Wed, 21 Nov 2007 06:40:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id lAL6e02V069679 for ; Wed, 21 Nov 2007 06:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id lAL6e0sC069678; Wed, 21 Nov 2007 06:40:00 GMT (envelope-from gnats) Resent-Date: Wed, 21 Nov 2007 06:40:00 GMT Resent-Message-Id: <200711210640.lAL6e0sC069678@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Volkov Andrey Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F24316A417 for ; Wed, 21 Nov 2007 06:39:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 5DC5F13C468 for ; Wed, 21 Nov 2007 06:39:47 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.1/8.14.1) with ESMTP id lAL6d2OO081127 for ; Wed, 21 Nov 2007 06:39:02 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.1/8.14.1/Submit) id lAL6d2wv081126; Wed, 21 Nov 2007 06:39:02 GMT (envelope-from nobody) Message-Id: <200711210639.lAL6d2wv081126@www.freebsd.org> Date: Wed, 21 Nov 2007 06:39:02 GMT From: Volkov Andrey To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/118168: [patch] multimedia/transcode. Add WITHOUT_X11 and WITHOUT_DVDREAD. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2007 06:40:06 -0000 >Number: 118168 >Category: ports >Synopsis: [patch] multimedia/transcode. Add WITHOUT_X11 and WITHOUT_DVDREAD. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Nov 21 06:40:00 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Volkov Andrey >Release: FreeBSD 6.2-STABLE i386 >Organization: Nolty >Environment: FreeBSD ns.nolty.ru 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #12: Mon Oct 29 16:07:30 YEKT 2007 root@ns.nolty.ru:/usr/obj/usr/src/sys/NNS i386 >Description: This patch prevents transcode to be compiled with X when WITHOUT_X11 is set. Transcode 1.0.4 compiles and works perfectly without heavy X11 libraries. I also introduced variable WITHOUT_DVDREAD. It is used to prevent libdvdread to be installed as a dependency. According to the 'configure' script, it is not required. This patch is very useful when transcode is used on a server. >How-To-Repeat: >Fix: Patch attached with submission follows: --- Makefile.orig 2007-11-21 01:50:54.000000000 +0500 +++ Makefile 2007-11-21 01:51:14.000000000 +0500 @@ -14,8 +14,7 @@ MAINTAINER= multimedia@FreeBSD.org COMMENT= A text-console utility for video stream processing -LIB_DEPENDS= dvdread.5:${PORTSDIR}/multimedia/libdvdread \ - jpeg.9:${PORTSDIR}/graphics/jpeg \ +LIB_DEPENDS= jpeg.9:${PORTSDIR}/graphics/jpeg \ mpeg2.0:${PORTSDIR}/multimedia/libmpeg2 \ avcodec.1:${PORTSDIR}/multimedia/ffmpeg BUILD_DEPENDS= iconv:${PORTSDIR}/converters/libiconv @@ -24,7 +23,6 @@ FAKEDIR= ${WRKDIR}/fake PLIST= ${WRKDIR}/plist USE_GETOPT_LONG=yes -USE_XLIB= yes USE_GMAKE= yes USE_LDCONFIG= yes WANT_SDL= yes @@ -35,7 +33,6 @@ SDL_CONFIG="${SDL_CONFIG}" CONFIGURE_ARGS+= --with-libavcodec-includes=${LOCALBASE}/include/ffmpeg \ --with-libavcodec-libs=${LOCALBASE}/lib \ - --with-libdvdread-prefix=${LOCALBASE} \ --with-libiconv-prefix=${LOCALBASE} \ --enable-oss \ --enable-gtk=no @@ -64,6 +61,18 @@ CONFIGURE_ARGS+= --enable-bktr .endif +.if !defined(WITHOUT_X11) +USE_XLIB= yes +CONFIGURE_ARGS+= --with-x +.endif + +.if !defined(WITHOUT_DVDREAD) +LIB_DEPENDS+= dvdread.5:${PORTSDIR}/multimedia/libdvdread +CONFIGURE_ARGS+= --with-libdvdread-prefix=${LOCALBASE} --enable-libdvdread +.else +CONFIGURE_ARGS+= --enable-libdvdread=no +.endif + .if defined(WITH_VORBIS) || exists(${LOCALBASE}/lib/libvorbis.so) LIB_DEPENDS+= vorbis.4:${PORTSDIR}/audio/libvorbis CONFIGURE_ARGS+= --with-vorbis-prefix=${LOCALBASE} --enable-vorbis @@ -178,6 +187,14 @@ @${ECHO_MSG} @${ECHO_MSG} "You can enable extra optimizations by defining WITH_OPTIMIZED_CFLAGS." .endif +.if !defined(WITHOUT_X11) + @${ECHO_MSG} + @${ECHO_MSG} "You can disable X modules by defining WITHOUT_X11." +.endif +.if !defined(WITHOUT_DVDREAD) + @${ECHO_MSG} + @${ECHO_MSG} "You can disable dvdread modules by defining WITHOUT_DVDREAD." +.endif .if !defined(WITH_FREETYPE) @${ECHO_MSG} @${ECHO_MSG} "You can enable text/subtitler modules by defining WITH_FREETYPE." >Release-Note: >Audit-Trail: >Unformatted: