From owner-cvs-all Sat Sep 14 12:13:49 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A968237B400; Sat, 14 Sep 2002 12:13:45 -0700 (PDT) Received: from critter.freebsd.dk (port757.uc1-esp.isdn-lan.cybercity.dk [212.242.98.245]) by mx1.FreeBSD.org (Postfix) with ESMTP id 72D2543E3B; Sat, 14 Sep 2002 12:13:44 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g8EJDIBQ056930; Sat, 14 Sep 2002 21:13:20 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Matthew Dillon Cc: Bruce Evans , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_bio.c src/sys/sys bio.h In-Reply-To: Your message of "Sat, 14 Sep 2002 12:08:37 PDT." <200209141908.g8EJ8bUd052972@apollo.backplane.com> Date: Sat, 14 Sep 2002 21:13:18 +0200 Message-ID: <56929.1032030798@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200209141908.g8EJ8bUd052972@apollo.backplane.com>, Matthew Dillon w rites: > >:In message <20020914032217.V10972-100000@gamplex.bde.org>, Bruce Evans writes: >: >:>Isn't the "correct" locking just splbio() in RELENG_4 (if this function were >:>merged, haha) and Giant in -current. bufwait() just uses splbio() >:>unconditionally. Of course, Giant is not really correct. >: >:Forget -stable. In -current Giant would currently be a usable >:default, except that it would likely perform worse than the timeout >:currently used. Down the road Giant is almost guaranteed to be >:wrong, and therefore I didn't want to employ at this time. >: >:-- >:Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 >:phk@FreeBSD.ORG | TCP/IP since RFC 956 >:FreeBSD committer | BSD since 4.3-tahoe >:Never attribute to malice what can adequately be explained by incompetence. > > Well, the buffer is owned at the time of the BIO_DONE and you have > a lock structure sitting right there, why not simply use the > lock structure's interlock? Note I said 'interlock' here, not the > main lock. struct bio != struct buf -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message