From owner-svn-src-all@FreeBSD.ORG Fri Feb 6 01:33:37 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7C2B7B8E; Fri, 6 Feb 2015 01:33:37 +0000 (UTC) Received: from mail-ig0-x22f.google.com (mail-ig0-x22f.google.com [IPv6:2607:f8b0:4001:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 424C7C2E; Fri, 6 Feb 2015 01:33:37 +0000 (UTC) Received: by mail-ig0-f175.google.com with SMTP id hn18so3959063igb.2; Thu, 05 Feb 2015 17:33:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=vOG1g7y0Gnq1OX91n42q3WoopzRp3bWroDa0hLC1GG4=; b=mWgHgjop/aKEC/wjXAgyas2+rTKKUiRIn5pfJhzkN/feWt6f64v6dFhu5CX0WYnX4F a/Ri23weudSW0MNDdrqkp4LmEkYHHY8cE7B7ll3a7J42WXuwNOzzVKGADq1eQSXJAjED AebvtiP4fHmOjG4JTV4Y9r534YNMu9B+bG2PUKziJneKUjV0e9NjRXTvnvQvHbosXcA0 aPt9L0WGmz1kkSSJtCJJwuof/jNb5w3gzL/lE7nTGYkqPDwCi7CXBJFCRIQ8JBjJQhBQ fid3KYQk6yUAwVBBHQHtFx6a5ofyxDynSjvD40oCpqKeCtfa6EsXgGPJpy9k/FEGh/cv LT3g== MIME-Version: 1.0 X-Received: by 10.107.12.196 with SMTP id 65mr7233462iom.71.1423186416687; Thu, 05 Feb 2015 17:33:36 -0800 (PST) Received: by 10.50.182.233 with HTTP; Thu, 5 Feb 2015 17:33:36 -0800 (PST) In-Reply-To: <201502060110.t161A58m067355@svn.freebsd.org> References: <201502060110.t161A58m067355@svn.freebsd.org> Date: Thu, 5 Feb 2015 17:33:36 -0800 Message-ID: Subject: Re: svn commit: r278303 - in head/sys: dev/cxgbe modules/cxgbe modules/cxgbe/if_cxl From: NGie Cooper To: Navdeep Parhar Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2015 01:33:37 -0000 On Thu, Feb 5, 2015 at 5:10 PM, Navdeep Parhar wrote: > Author: np > Date: Fri Feb 6 01:10:04 2015 > New Revision: 278303 > URL: https://svnweb.freebsd.org/changeset/base/278303 > > Log: > cxgbe(4): Add a minimal if_cxl module that pulls in the real driver as > a dependency. This ensures "ifconfig cxl ..." does the right thing > even when it's run with no driver loaded. > > if_cxl.ko is the tiniest module in /boot/kernel. A couple things: 1. cxl(4) doesn't have a manpage: $ man 4 cxl No manual entry for cxl $ man 4 if_cxl No manual entry for if_cxl 2. This could have been done with hardlinks to avoid creating an additional driver (and on the plus side it saves disk space): $ git diff Makefile diff --git a/sys/modules/cxgbe/if_cxgbe/Makefile b/sys/modules/cxgbe/if_cxgbe/Makefile index 32347f4..b00ee0a 100644 --- a/sys/modules/cxgbe/if_cxgbe/Makefile +++ b/sys/modules/cxgbe/if_cxgbe/Makefile @@ -25,5 +25,7 @@ SRCS+= t4_tracer.c CFLAGS+= -I${CXGBE} +LINKS+= ${KMOD}.ko if_cxl.ko + .include CFLAGS+= ${GCC_MS_EXTENSIONS} This is basically what I'm going to set out and do to fix this PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=186449 (it's another item that irritates me with misnamed drivers, like ixgbe.ko used to be...). Using hardlinks instead of renaming the driver is preferred because it makes MFCing possible without breaking loader.conf for sysadmins. In general, major version steps (CURRENT) should use if_ consistently. Thanks!