Date: Tue, 15 Mar 2016 02:23:17 -0400 From: Michael McConville <mmcco@mykolab.com> To: Ben Woods <woodsb02@gmail.com> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: Re: Int overflow in dhclient(1) Message-ID: <20160315062316.GC344@thinkpad.swarthmore.edu> In-Reply-To: <CAOc73CCVaK5DEAhkyg9P1=oKo2vhj7xDNPhHJDJixS%2B-0uALmA@mail.gmail.com> References: <20160315015542.GA61626@thinkpad.swarthmore.edu> <CAOc73CCVaK5DEAhkyg9P1=oKo2vhj7xDNPhHJDJixS%2B-0uALmA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Ben Woods wrote: > On Tuesday, 15 March 2016, Michael McConville <mmcco@mykolab.com> wrote: > > > I sent this a few weeks ago, but it never got applied: > > > > https://marc.info/?l=freebsd-net&m=145392057613453&w=2 > > > > Here's my explanation for the same fix in OpenBSD: > > > > https://marc.info/?l=openbsd-tech&m=145377854103866&w=2 > > > > Thanks for your time, > > Michael > > > > > > Index: sbin/dhclient/dhclient.c > > =================================================================== > > --- sbin/dhclient/dhclient.c (revision 296886) > > +++ sbin/dhclient/dhclient.c (working copy) > > @@ -138,7 +138,7 @@ > > findproto(char *cp, int n) > > { > > struct sockaddr *sa; > > - int i; > > + unsigned int i; > > > > if (n == 0) > > return -1; > > > > Seems like a bug report should be raised so this one doesn't get > lost/ignored. > > Would you be able to raise one here please? > https://bugs.freebsd.org/ I'll wait a day or two to see if a developer picks it up. Opening a bug report is a lot of work for a pretty straight-forward addition of a single token.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160315062316.GC344>