From owner-svn-src-all@FreeBSD.ORG Fri Jan 2 16:43:11 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 44CF624E; Fri, 2 Jan 2015 16:43:11 +0000 (UTC) Received: from c.mail.sonic.net (c.mail.sonic.net [64.142.111.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2AD371BD4; Fri, 2 Jan 2015 16:43:10 +0000 (UTC) Received: from comporellon.tachypleus.net (polaris.tachypleus.net [75.101.50.44]) (authenticated bits=0) by c.mail.sonic.net (8.14.9/8.14.9) with ESMTP id t02Gh8lp017273 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 2 Jan 2015 08:43:08 -0800 Message-ID: <54A6CA9C.2050506@freebsd.org> Date: Fri, 02 Jan 2015 08:43:08 -0800 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Konstantin Belousov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r276522 - head/sys/amd64/amd64 References: <201501020100.t0210dIx064363@svn.freebsd.org> In-Reply-To: <201501020100.t0210dIx064363@svn.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Sonic-CAuth: UmFuZG9tSVaLfxEGmusTpYuoEZDlNMwrcm1i1iY7PI+0JO7IvCPjM1lhZOPjYwSv+fM5kAt/hmwdyDYgGRHXZ1U6TMqpJ1hkDgBkFxYLeDc= X-Sonic-ID: C;hFdnbp6S5BG0cPCsS5uE/A== M;2uW+bp6S5BG0cPCsS5uE/A== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jan 2015 16:43:11 -0000 Other architectures (PowerPC, for example) seem to have this same code there by copy and paste. Any chance you could do a global sweep? -Nathan On 01/01/15 17:00, Konstantin Belousov wrote: > Author: kib > Date: Fri Jan 2 01:00:38 2015 > New Revision: 276522 > URL: https://svnweb.freebsd.org/changeset/base/276522 > > Log: > Actually remove GIANT_REQUIRED, declared but not done in r263475. > Style. > > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > > Modified: > head/sys/amd64/amd64/mem.c > > Modified: head/sys/amd64/amd64/mem.c > ============================================================================== > --- head/sys/amd64/amd64/mem.c Fri Jan 2 00:57:40 2015 (r276521) > +++ head/sys/amd64/amd64/mem.c Fri Jan 2 01:00:38 2015 (r276522) > @@ -81,8 +81,6 @@ memrw(struct cdev *dev, struct uio *uio, > int error, o, sflags; > vm_offset_t addr, eaddr; > > - GIANT_REQUIRED; > - > error = 0; > c = 0; > sflags = curthread_pflags_set(TDP_DEVMEMIO); > @@ -110,8 +108,7 @@ kmemphys: > } > error = uiomove((void *)v, (int)c, uio); > continue; > - } > - else if (dev2unit(dev) == CDEV_MINOR_KMEM) { > + } else if (dev2unit(dev) == CDEV_MINOR_KMEM) { > v = uio->uio_offset; > > if (v >= DMAP_MIN_ADDRESS && v < DMAP_MAX_ADDRESS) { >