From owner-freebsd-arch@FreeBSD.ORG Wed Oct 14 07:41:08 2009 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9860E106568D for ; Wed, 14 Oct 2009 07:41:08 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.159]) by mx1.freebsd.org (Postfix) with ESMTP id 276238FC13 for ; Wed, 14 Oct 2009 07:41:07 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id 22so195988fge.13 for ; Wed, 14 Oct 2009 00:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=QsbZPjNBo1VxDLb6rIEzPMgADnv4SSKqC4eUWeoenpU=; b=X/xo9BhD7g+C3MsAAQB/fZUHnUf0zvazncSpinBHWUvJjrh3qOP87MHoA/8R3n4HAY XTSSyTMZBubICJR4uCm+Uhq8vaQ3yCqpNIo9aLLpNDzf73d/pNRsDaTxm6rtV429pJM0 sSfCcnR0obfWzyECW/Fu708uWrja9ZXTerQsA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=Ko7YZlg6A8b0Zr0uYHdPIppKoofjSzsRNftMzHKAmc2CIXTVamzgRT38TapOqPtXuE Bl2CiAuzH00xCrRYEJYwYoMOPI/M48IqfLgUlQc44HDpMjXVIWSQfiwHbQD11620T6W8 58KAM5s1aDs8vKeE+aTf9FTm0hOO5JlehGSe0= Received: by 10.102.177.33 with SMTP id z33mr3431601mue.87.1255504687642; Wed, 14 Oct 2009 00:18:07 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id 23sm1379429mum.14.2009.10.14.00.18.06 (version=SSLv3 cipher=RC4-MD5); Wed, 14 Oct 2009 00:18:07 -0700 (PDT) Sender: Alexander Motin Message-ID: <4AD57B2C.8070606@FreeBSD.org> Date: Wed, 14 Oct 2009 10:18:04 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20090901) MIME-Version: 1.0 To: John Baldwin References: <200909301732.20589.jhb@freebsd.org> <1255483383.00172964.1255470604@10.7.7.3> In-Reply-To: <1255483383.00172964.1255470604@10.7.7.3> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-arch@freebsd.org Subject: Re: Interrupt Descriptions X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 07:41:08 -0000 John Baldwin wrote: > On Wednesday 30 September 2009 5:32:20 pm John Baldwin wrote: >> A few folks have asked recently for the ability to add descriptive strings > to >> registered interrupt handlers. This is especially true since the advent of >> MSI with multiple interrupts per device. I hacked up a prototype today that >> adds a new 'bus_describe_intr()' that takes the IRQ resource, the void * >> cookie returned by bus_setup_intr() and var args description and appends > that >> to the interrupt name in the thread and vmstat -i info. The current patch >> only has the MI bits and the MD bits for amd64 as well as a sample change to >> the igb(4) driver. >> >> The patch is at http://www.FreeBSD.org/~jhb/patches/intr_describe.patch. >> >> An example from this patch is: >> >>> vmstat -i >> interrupt total rate >> irq1: atkbd0 8 0 >> irq4: uart0 751 5 >> irq6: fdc0 6 0 >> irq14: ata0 36 0 >> irq20: uhci0 20 0 >> irq23: uhci3 ehci0 2 0 >> irq28: mpt0 1661 11 >> irq256: igb0:tx 0 880 6 >> irq257: igb0:rx 0 1098 7 >> irq258: igb0:link 3 0 >> irq259: igb1:tx 0 1 0 >> irq260: igb1:rx 0 134 0 >> irq261: igb1:link 3 0 > > Do folks feel that the issues with the intrnames and intrcnt API warrant > delaying this work, or do folks have any objections to the proposed > bus_describe_intr() API? Personally I think that intrnames and intrcnt are > certainly broken, but that they have been broken for quite a while and that > these changes do not make them more broken than they currently are. Also, I > think that any fixes to intrcnt/intrnames would be orthogonal to > bus_describe_intr(). Just some 50 cents on topic: it would be nice if `vmstat -i` was able to show all (more then 2) consumers of shared interrupt instead of "cbb0 wpi0+". I haven't looked who actually limit this and why, so it's just a wish. -- Alexander Motin