Date: Mon, 3 Sep 2001 21:47:37 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Mike Heffner <mheffner@vt.edu> Cc: chrisw@Wicklein.ORG, current@FreeBSD.ORG, kris@FreeBSD.ORG Subject: Re: syslogd: Too many '/' in "/dev//console" Message-ID: <20010903214737.A41311@xor.obsecurity.org> In-Reply-To: <XFMail.20010904002828.mheffner@vt.edu>; from mheffner@vt.edu on Tue, Sep 04, 2001 at 12:28:28AM -0400 References: <20010903204142.87BDC37B405@hub.freebsd.org> <XFMail.20010904002828.mheffner@vt.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 04, 2001 at 12:28:28AM -0400, Mike Heffner wrote: >=20 > On 03-Sep-2001 chrisw@Wicklein.ORG wrote: > | Between last weekend and this weekend, something changed in syslogd=20 > | seems to have resulted in this boot-time error. The syslogd.c deltas= =20 > | from 1.82 -> 1.83 look suspect since the handling of relevant variables= =20 > | has changed. >=20 > This change looks wrong: >=20 >=20 > @@ -1679,16 +1659,17 @@ cfline(line, f, prog, host) > f->f_type =3D F_CONSOLE; > else > f->f_type =3D F_TTY; > - (void)strcpy(f->f_un.f_fname, p + sizeof _PATH_DEV -= 1); > + (void)strlcpy(f->f_un.f_fname, p + sizeof(_PATH_DEV = - 1), > ^^^^^^^^^^^= ^^^^ > + sizeof(f->f_un.f_fname)); > } else { Oops, that was a last minute change to try and impose some style consistency on my changes (if not the entire file). I'll fix it. Kris --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE7lFzpWry0BWjoQKURAvfPAJ0b2xNnD+risi1zSVXqoN6xP2i8UACfeTmR sthwD4CWk9P+uMBYWY0K9Os= =9ydR -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010903214737.A41311>