Date: Mon, 2 Dec 2019 10:27:00 -0800 From: John Baldwin <jhb@FreeBSD.org> To: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355241 - head/sys/kern Message-ID: <6cd7168c-8212-3001-fb8f-09ecaca93e61@FreeBSD.org> In-Reply-To: <201911301933.xAUJX2DB030548@repo.freebsd.org> References: <201911301933.xAUJX2DB030548@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/30/19 11:33 AM, Mateusz Guzik wrote: > Author: mjg > Date: Sat Nov 30 19:33:02 2019 > New Revision: 355241 > URL: https://svnweb.freebsd.org/changeset/base/355241 > > Log: > smp: cast the read in quiesce_all_critical through void * > > Fixes compilation on some 32-bit arm platforms. > > Sponsored by: The FreeBSD Foundation > > Modified: > head/sys/kern/subr_smp.c > > Modified: head/sys/kern/subr_smp.c > ============================================================================== > --- head/sys/kern/subr_smp.c Sat Nov 30 19:21:29 2019 (r355240) > +++ head/sys/kern/subr_smp.c Sat Nov 30 19:33:02 2019 (r355241) > @@ -952,7 +952,7 @@ quiesce_all_critical(void) > break; > cpu_spinwait(); > newtd = (struct thread *) > - atomic_load_acq_ptr((u_long *)pcpu->pc_curthread); > + atomic_load_acq_ptr((void *)pcpu->pc_curthread); Why not uintptr_t *? I think that's the defined type for atomic_*_ptr anyway? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6cd7168c-8212-3001-fb8f-09ecaca93e61>