From owner-freebsd-net@FreeBSD.ORG  Wed Mar 17 03:52:55 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 74DD416A4CE
	for <freebsd-net@freebsd.org>; Wed, 17 Mar 2004 03:52:55 -0800 (PST)
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by mx1.FreeBSD.org (Postfix) with SMTP id 9F65F43D6B
	for <freebsd-net@freebsd.org>; Wed, 17 Mar 2004 03:52:54 -0800 (PST)
	(envelope-from dwmalone@maths.tcd.ie)
Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <aa43952@salmon>; 17 Mar 2004 11:52:53 +0000 (GMT)
To: freebsd-net@freebsd.org
X-Request-Do: 
Date: Wed, 17 Mar 2004 11:52:53 +0000
From: David Malone <dwmalone@maths.tcd.ie>
Message-ID: <200403171152.aa43952@salmon.maths.tcd.ie>
Subject: PPPoE buglet...
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Mar 2004 11:52:55 -0000

I spent a while trying to get PPPoE going through a Netopia smart
modem last night. To cut a long story short, the values for
PTT_RELAY_SID in src/sys/netgraph/ng_pppoe.h are wrong (at least
when compared with tcpdump, linux and the RFC). We have:

#if BYTE_ORDER == BIG_ENDIAN
#define PTT_RELAY_SID   (0x0106)
#else
#define PTT_RELAY_SID   (0x0601)
#endif

but we should have:

#if BYTE_ORDER == BIG_ENDIAN
#define PTT_RELAY_SID   (0x0110)
#else
#define PTT_RELAY_SID   (0x1001)
#endif

Anyone object to my fixing it? The only thing I can think of that
it might break would be people using ng_pppoe as a PPPoE relay with
only ng_pppoe PPPoE clients.

	David.