From owner-freebsd-isdn Wed May 19 4:25:11 1999 Delivered-To: freebsd-isdn@freebsd.org Received: from bitbucket.extern.uniface.nl (nettle.uniface.nl [193.78.88.130]) by hub.freebsd.org (Postfix) with ESMTP id 9756514DE1 for ; Wed, 19 May 1999 04:25:08 -0700 (PDT) (envelope-from bert_driehuis@nl.compuware.com) Received: (from smtpd@localhost) by bitbucket.extern.uniface.nl (8.7.6/8.7.3r) id NAA19688; Wed, 19 May 1999 13:24:58 +0200 (MET DST) Received: from trashcan.nl.compuware.com(172.16.16.52) via SMTP by recyclebin.nl.compuware.com, id smtpd019624; Wed May 19 13:24:56 1999 Received: from nl.compuware.com (c1111.nl.compuware.com [172.16.16.36]) by trashcan.nl.compuware.com (Postfix) with ESMTP id D72522F33; Wed, 19 May 1999 13:24:55 +0200 (CEST) Message-ID: <37429F87.910F1A95@nl.compuware.com> Date: Wed, 19 May 1999 13:24:55 +0200 From: Bert Driehuis Organization: Compuware Europe, Amsterdam X-Mailer: Mozilla 4.08 [en] (X11; I; BSD/OS 3.1 i386) MIME-Version: 1.0 To: Marcel Moolenaar Cc: isdn@FreeBSD.ORG Subject: Re: Rename on SIGUSR1 for isdnd References: <374288D1.8D3F25DD@scc.nl> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Marcel Moolenaar wrote: > The reason for the patch is more "emotional" than technical. Firstly, I don't > like fiddling with things that are under the control of running programs. It > makes matters more complicated than strictly necessary. Secondly, I like > clear functionality. Closing and reopening files makes sense only when > accompanied by some external (from the isdnd point of view) action. Rotation policy should probably be implemented in a shell script. Daemons that rotate their own logfile just make things more complicated. The "correct" way of handling it is to let the daemon close and the re-open the log file upon receipt of a signal, so that the admin can create a script that does mv isdnd.log isdnd.log.0 kill -1 `cat /var/run/isdnd.pid` gzip -9 isdnd.log.0 or whatever s/he deems appropriate. Renaming it in the daemon will screw someone up, somewhere. Look at the history of log file rotation in Squid if you want to know where not to go. Cheers, -- Bert -- Bert Driehuis, MIS -- bert_driehuis@nl.compuware.com -- +31-20-3116119 The grand leap of the whale up the Fall of Niagara is esteemed, by all who have seen it, as one of the finest spectacles in nature. -- Benjamin Franklin. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message