Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Mar 2013 08:04:44 +0000 (UTC)
From:      Pyun YongHyeon <yongari@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r247873 - stable/8/sys/dev/msk
Message-ID:  <201303060804.r2684ill029930@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: yongari
Date: Wed Mar  6 08:04:44 2013
New Revision: 247873
URL: http://svnweb.freebsd.org/changeset/base/247873

Log:
  MFC r247382:
    RX checksum offloading on old Yukon controllers seem to cause more
    problems.  Disable RX checksum offloading on controllers that don't
    use new descriptor format but give chance to enable it with
    ifconfig(8).

Modified:
  stable/8/sys/dev/msk/if_msk.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/dev/   (props changed)
  stable/8/sys/dev/msk/   (props changed)

Modified: stable/8/sys/dev/msk/if_msk.c
==============================================================================
--- stable/8/sys/dev/msk/if_msk.c	Wed Mar  6 08:03:26 2013	(r247872)
+++ stable/8/sys/dev/msk/if_msk.c	Wed Mar  6 08:04:44 2013	(r247873)
@@ -1696,6 +1696,12 @@ msk_attach(device_t dev)
 			ifp->if_capabilities |= IFCAP_VLAN_HWCSUM;
 	}
 	ifp->if_capenable = ifp->if_capabilities;
+	/*
+	 * Disable RX checksum offloading on controllers that don't use
+	 * new descriptor format but give chance to enable it.
+	 */
+	if ((sc_if->msk_flags & MSK_FLAG_DESCV2) == 0)
+		ifp->if_capenable &= ~IFCAP_RXCSUM;
 
 	/*
 	 * Tell the upper layer(s) we support long frames.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303060804.r2684ill029930>