From owner-cvs-all  Mon Feb 28  2:55:51 2000
Delivered-To: cvs-all@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id C7D0337B755; Mon, 28 Feb 2000 02:55:44 -0800 (PST)
	(envelope-from jkoshy@FreeBSD.org)
Received: (from jkoshy@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id CAA21498;
	Mon, 28 Feb 2000 02:55:44 -0800 (PST)
	(envelope-from jkoshy@FreeBSD.org)
Date: Mon, 28 Feb 2000 02:55:44 -0800 (PST)
From: <jkoshy@FreeBSD.org>
Message-Id: <200002281055.CAA21498@freefall.freebsd.org>
X-Mailer: exmh version 2.0.2 2/24/98
To: Warner Losh <imp@village.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/pccard/pccardd readcis.h
In-Reply-To: Your message of "Mon, 28 Feb 2000 00:52:18 MST."
             <200002280752.AAA71066@harmony.village.org> 
Mime-Version: 1.0
Content-Type: text/plain
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk



: jkoshy      2000/02/27 21:20:30 PST
:   Modified files:        (Branch: RELENG_3)
:     usr.sbin/pccard/pccardd readcis.h 
:   Log:
:   MFC: {rev 1.11} Increase `CIS_MAXSTR' to 254.  This allows pccardd(8) in
:        -STABLE to recognize PCMCIA cards with long identification strings.
:   
:   Reviewed by:	Warner Losh <imp@village.org>

imp> Not MFC: entries in pccard.conf.sample that needed to be expaneded by
imp> this change.  Likely worth a heads up to -stable.

Good idea.  A "heads up" message has been sent.

We need a list of cards in -STABLE's pccard.conf.sample that had their
descriptions truncated on account of the earlier too small read size.

nemesis$ grep ^card /usr/src/etc/pccard.conf.sample | \
	sed -ne 's/^.*"\(.*\)"[        ]"\(.*\)".*/\1  \2/p' |\
	awk -F' ' 'length($2) >= 29 { print }'

3Com    		3C574-TX Fast EtherLink PC Ca
Linksys 		Combo PCMCIA EthernetCard (EC

EAGLE Technology        NE200 ETHERNET LAN MBH10303  
Intel   		EtherExpress(TM) PRO/100 PC C
Xircom  		CreditCard Ethernet 10/100 + 
Xircom  		CreditCard Modem 56 - GlobalA

Of these, only the first two seem to have been corrected in -CURRENT (patch
for -STABLE enclosed). Anyone have an idea of the 'correct' description
strings for the others?  They look truncated, but I can't be sure.

Regards,
Koshy
<jkoshy@freebsd.org>

Index: pccard.conf.sample
===================================================================
RCS file: /home/ncvs/src/etc/pccard.conf.sample,v
retrieving revision 1.24.2.16
diff -u -r1.24.2.16 pccard.conf.sample
--- pccard.conf.sample	1999/12/27 08:41:36	1.24.2.16
+++ pccard.conf.sample	2000/02/28 14:49:33
@@ -112,7 +112,7 @@
 	remove	/sbin/ifconfig ep0 delete
 
 # 3Com Fast Etherlink 3C574TX
-card "3Com" "3C574-TX Fast EtherLink PC Ca"
+card "3Com" "3C574-TX Fast EtherLink PC Card"
 	config	0x1 "ep0" ? 0x1
 	insert	echo 3Com Fast Etherlink 3C574TX inserted
 	insert	/etc/pccard_ether ep0
@@ -128,7 +128,7 @@
 	remove	/sbin/ifconfig ed0 delete
 
 # Linksys Combo PCMCIA EthernetCard (model EC2T on box) 
-card "Linksys" "Combo PCMCIA EthernetCard (EC" 
+card "Linksys" "Combo PCMCIA EthernetCard (EC2T)" 
 	config 0x1 "ed0" ? 
 	insert echo Linksys Ethernet inserted 
 	insert /etc/pccard_ether ed0 





To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message