From owner-cvs-all Sat Jun 22 22:27:12 2002 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id 5822637B403; Sat, 22 Jun 2002 22:27:10 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1192) id 35515AE163; Sat, 22 Jun 2002 22:27:10 -0700 (PDT) Date: Sat, 22 Jun 2002 22:27:10 -0700 From: Alfred Perlstein To: Alan Cox Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_mmap.c Message-ID: <20020623052710.GK53232@elvis.mu.org> References: <200206230148.g5N1mN795443@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200206230148.g5N1mN795443@freefall.freebsd.org> User-Agent: Mutt/1.3.27i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Alan Cox [020622 18:48] wrote: > alc 2002/06/22 18:48:23 PDT > > Modified files: > sys/vm vm_mmap.c > Log: > o Remove the unnecessary acquisition and release of Giant around fdrop() > in mmap(2). I think fdrop() may need Giant in case a race with a thread makes it the instance of fdrop() that leads to fclose() being called which can call down into the VFS code. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message