Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 May 2015 17:41:53 +0200
From:      Mathieu Arnold <m@absolight.fr>
To:        Ed Maste <emaste@freebsd.org>
Cc:        Ian Lepore <ian@freebsd.org>, src-committers@freebsd.org, Eitan Adler <eadler@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Garrett Cooper <yaneurabeya@gmail.com>
Subject:   Re: svn commit: r282985 - in head/sys: arm/annapurna arm/annapurna/alpine arm/annapurna/alpine/hal arm/conf boot/fdt/dts/arm
Message-ID:  <CA08581F265A5567A799C4C2@ogg.in.absolight.net>
In-Reply-To: <CAPyFy2CJP4EPBw9jKgsiAzbgBcxpyYXkMa5F7SBV2uBjjw=F5Q@mail.gmail.com>
References:  <201505151825.t4FIPnxJ099637@svn.freebsd.org> <CAJ-Vmomw3QeX4QfwN3ZH%2BcgJGbcJJT0LyjF8d%2B2EX0vExQzYog@mail.gmail.com> <059F2C65-F92D-445C-B603-0FAE0CAF976D@gmail.com> <1431877581.91685.49.camel@freebsd.org> <CAF6rxg=kNFBhDWY0VZKWUb=sVRc-XRtJVGOquEAX=jcdq_CkYA@mail.gmail.com> <7F73A915E7DF0EE8DC6149EC@atuin.in.mat.cc> <1431957864.91685.57.camel@freebsd.org> <64FE26BD563665E5F1B3D0C8@ogg.in.absolight.net> <CAPyFy2CJP4EPBw9jKgsiAzbgBcxpyYXkMa5F7SBV2uBjjw=F5Q@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
+--On 18 mai 2015 10:52:29 -0400 Ed Maste <emaste@freebsd.org> wrote:
| On 18 May 2015 at 10:11, Mathieu Arnold <m@absolight.fr> wrote:
|> 
|> Mmmm, if this can be done only for base, and not for ports, sure, but
|> ports need to be able to add patches with CRLF endings, because upstream
|> software comes in all flavors, including CRLF files we need to be able
|> to patch.
| 
| Sure it could, we could configure it however we want.
| 
| Note that we'll likely need to support CRLF in base anyway - one
| obvious example is test cases for CRLF handling in various tools.  I'd
| imagine we could add an SVN keyword like fbsd:crlf=yes, along the
| lines of fbsd:nokeywords=yes.
| 
| Do you know how common CRLF or partial CRLF files are in the ports
| tree?  If it's only a handful that scheme could work there too.

$ ag -l '\r' /usr/ports/|wc -l
      95

there's a bit more than a handful, but it could work, yes.  If you want to
have a look at a typical one, /usr/ports/shells/ibsh/files/patch-Makefile
:-)

But I think Eitan was talking about Phabricator, in this case, it'd need to
work there too.

-- 
Mathieu Arnold



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA08581F265A5567A799C4C2>