Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 26 May 2013 18:59:00 GMT
From:      Michael Moll <kvedulv@kvedulv.de>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/178994: x11-drivers/xf86-input-mouse: compile error with gcc47
Message-ID:  <201305261859.r4QIx0ZH021447@oldred.FreeBSD.org>
Resent-Message-ID: <201305261900.r4QJ02Sw020393@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         178994
>Category:       ports
>Synopsis:       x11-drivers/xf86-input-mouse: compile error with gcc47
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 26 19:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Michael Moll
>Release:        9-STABLE
>Organization:
>Environment:
FreeBSD emperor.kvedulv.de 9.1-STABLE FreeBSD 9.1-STABLE #0 r250935M: Fri May 24 15:19:09 CEST 2013     mmoll@emperor.kvedulv.de:/usr/obj/svn/base/stable/9/sys/EMPEROR  amd64
>Description:
[...]
  CC       bsd_mouse.lo
mouse.c:156:9: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
mouse.c: In function 'MousePreInit':
mouse.c:932:22: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
bsd_mouse.c:197:9: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
bsd_mouse.c:198:9: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
bsd_mouse.c:199:9: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
bsd_mouse.c:200:9: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
bsd_mouse.c:201:9: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
bsd_mouse.c:202:9: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
bsd_mouse.c:203:9: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
bsd_mouse.c:204:9: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
bsd_mouse.c:205:9: warning: initialization discards 'const' qualifier from pointer target type [enabled by default]
bsd_mouse.c: In function 'SetupAuto':
bsd_mouse.c:225:9: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
mouse.c: In function 'MousePostEvent':
mouse.c:2366:18: warning: variable 'mousepriv' set but not used [-Wunused-but-set-variable]
bsd_mouse.c: In function 'CheckProtocol':
bsd_mouse.c:151:30: error: array subscript is above array bounds [-Werror=array-bounds]
cc1: some warnings being treated as errors
*** [bsd_mouse.lo] Error code 1
1 error
*** [all-recursive] Error code 1
1 error
*** [all] Error code 2
1 error

>How-To-Repeat:

>Fix:
A patch from Debian/kfreebsd is attached

Patch attached with submission follows:

From: Robert Millan <rmh@debian.org>
Subject: Work around gcc bug resulting in build failure

./../src/bsd_mouse.c: In function 'CheckProtocol':
./../src/bsd_mouse.c:142:30: error: array subscript is above array bounds [-Werror=array-bounds]

Debian bug#665390.

Followup-From: Petr Salinger <Petr.Salinger@seznam.cz>
Followup-Bug: #681506

Index: xserver-xorg-input-mouse/src/bsd_mouse.c
===================================================================
--- xserver-xorg-input-mouse.orig/src/bsd_mouse.c
+++ xserver-xorg-input-mouse/src/bsd_mouse.c
@@ -139,10 +139,10 @@ CheckProtocol(const char *protocol)
 {
     int i;
 
-    for (i = 0; internalNames[i]; i++)
+    for (i = -1; internalNames[++i];)
 	if (xf86NameCmp(protocol, internalNames[i]) == 0)
 	    return TRUE;
-    for (i = 0; miscNames[i]; i++)
+    for (i = -1; miscNames[++i];)
 	if (xf86NameCmp(protocol, miscNames[i]) == 0)
 	    return TRUE;
     return FALSE;


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305261859.r4QIx0ZH021447>