Date: Tue, 6 Oct 2015 14:05:38 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Warner Losh <imp@bsdimp.com> Cc: Bryan Drewery <bdrewery@freebsd.org>, Warner Losh <imp@freebsd.org>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>, <sjg@juniper.net> Subject: Re: svn commit: r288911 - head/share/mk Message-ID: <20169.1444165538@chaos> In-Reply-To: <8D5D1CE5-BC57-464D-9C47-63EFF4C1CF2F@bsdimp.com> References: <201510060418.t964Innu071170@repo.freebsd.org> <56140CAD.8080200@FreeBSD.org> <8D5D1CE5-BC57-464D-9C47-63EFF4C1CF2F@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh <imp@bsdimp.com> wrote: > > The sys.mk change to include src.conf breaks building ports in a sub-dir > > of src. Meaning, /usr/src/ports/. The MAKESYSPATH with '.../share/mk' > > finds /usr/src/share/mk and runs off with all of the src.*.mk stuff long > > before the port Makefile includes bsd.port.mk, from > > /usr/src/share/mk/bsd.port.mk, which has a _WITHOUT_SRCCONF=3D guard set > > on it to avoid bsd.own.mk from including src.conf. But because sys.mk > > is already included long before this, src.conf is already included and > > anything handled in sys.mk has no real way to respect _WITHOUT_SRCCONF > > unless it is in the environment >=20 > Yuck! >=20 > But the real problem here is MAKESYSPATH of =E2=80=A6/share/mk. That was = a > hack until we had something like SRCTOP that we could use for finding > the right stuff and for individual builds. So if we can solve that > part of th but you only get SRCTOP as a consequence of finding the right sys.mk et al. Which presumes you have MAKESYSPATH set correctly. Ie. you find the right src.sys.env.mk and it can set SRCTOP based on knowing its own location. A bit of chicken & egg...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20169.1444165538>