Date: Thu, 9 Dec 2004 13:53:19 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Luigi Rizzo <rizzo@icir.org> Cc: ipfw@freebsd.org Subject: Re: strncmp usage in ipfw Message-ID: <20041209215319.GA12303@odin.ac.hmc.edu> In-Reply-To: <20041130041932.B91746@xorpc.icir.org> References: <20041129192514.GA7331@odin.ac.hmc.edu> <20041130041932.B91746@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--OgqxwSJOaUobr8KG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Tue, Nov 30, 2004 at 04:19:32AM -0800, Luigi Rizzo wrote:
> i believe the original, old ipfw code used strncmp() to allow for
> abbreviations. When i rewrote ipfw2 i did not feel like removing
> the feature for fear of introducing backward compatibility problems
> with existing files. However I agree that this introduces a
> maintainability nightmare and i believe we should move to strcmp(),
> especially given that with ipfw2 new option names are coming out
> quite frequently.
OK, that makes sense.
I'd like to propose the following plan:
- Disallow new strncmp instances in all branches.
- remove strncmp usage in HEAD with the intention of explicitly adding
back needed abbreviations when those abbreviations are both:
- sane (no single letter appreviations, reasionable edit distance
from other options, either obvious shorthand or reasionbly mnemonic).
- actually used be someone (this is key, espeicaly since there are
hundreds of possiable values and this isn't a documented
feature as far as I can tell.)
If need be we could implement a more complex stratigy for deprecation
where we use a new matching function and warn about short matches, but
I'm not sure that's necessicary.
-- Brooks
--OgqxwSJOaUobr8KG
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQFBuMlOXY6L6fI4GtQRAn4VAKC9ifH3iQJ9lhQnL/vuZahFrT/iMACeN73J
/KIHi8HQOZClfeuTLcM7MMY=
=jg7M
-----END PGP SIGNATURE-----
--OgqxwSJOaUobr8KG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041209215319.GA12303>