From owner-cvs-src@FreeBSD.ORG Wed Jan 17 16:08:32 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9CF0016A40F; Wed, 17 Jan 2007 16:08:32 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 3EAE913C442; Wed, 17 Jan 2007 16:08:32 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id l0HG8PU0054806; Wed, 17 Jan 2007 11:08:30 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Xin LI Date: Wed, 17 Jan 2007 11:05:35 -0500 User-Agent: KMail/1.9.1 References: <200701171505.l0HF5qGd068469@repoman.freebsd.org> In-Reply-To: <200701171505.l0HF5qGd068469@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701171105.36393.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 17 Jan 2007 11:08:30 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2459/Tue Jan 16 17:03:34 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/ddb db_command.c db_thread.c src/sys/vm vm_object.c vm_pageout.c src/sys/i386/i386 pmap.c src/sys/i386/ibcs2 ibcs2_sysvec.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2007 16:08:32 -0000 On Wednesday 17 January 2007 10:05, Xin LI wrote: > delphij 2007-01-17 15:05:52 UTC > > FreeBSD src repository > > Modified files: > sys/ddb db_command.c db_thread.c > sys/vm vm_object.c vm_pageout.c > sys/i386/i386 pmap.c > sys/i386/ibcs2 ibcs2_sysvec.c > Log: > Use FOREACH_PROC_IN_SYSTEM instead of using its unrolled form. I actually think this macro is actually not that useful and I'd rather we get rid of it. :) For one thing zombies are still processes and this doesn't cover those, so the name is a bit misleading. However, this is a minor thing, and I can see that the kernel should be consistent one way or another. I'd just vote for being consistent by removing FOREACH_PROC and FOREACH_THREAD. The kernel doesn't use wrappers for other lists, it just uses LIST_FOREACH and TAILQ_FOREACH directly. -- John Baldwin